-
Notifications
You must be signed in to change notification settings - Fork 14.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(Dashboard): Missing dashboardId when refreshing Explore #17380
Conversation
Codecov Report
@@ Coverage Diff @@
## master #17380 +/- ##
==========================================
- Coverage 77.07% 77.06% -0.01%
==========================================
Files 1036 1036
Lines 55756 55759 +3
Branches 7630 7633 +3
==========================================
Hits 42972 42972
- Misses 12529 12532 +3
Partials 255 255
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
/testenv up |
@geido Ephemeral environment spinning up at http://35.86.162.87:8080. Credentials are |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Ephemeral environment shutdown and build artifacts deleted. |
SUMMARY
This PR fixes an issue for which the
dashboardId
was lost when refreshing Explore.BEFORE
Fixes #17244
AFTER
DEV.Superset.mp4
TESTING INSTRUCTIONS
ADDITIONAL INFORMATION