Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(chart): Support ingressClassName #17197

Closed
wants to merge 4 commits into from

Conversation

Tonkonozhenko
Copy link

SUMMARY

Support ingressClassName in ingerss

ADDITIONAL INFORMATION

  • Has associated issue:
  • Required feature flags:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

@Tonkonozhenko
Copy link
Author

@craig-rueda please review

Copy link
Member

@craig-rueda craig-rueda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You need to bump the version

Copy link
Member

@craig-rueda craig-rueda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You need to bump the version

@jayakrishnankk
Copy link
Contributor

Bump this:

version: 0.3.10

@Tonkonozhenko
Copy link
Author

@craig-rueda @jayakrishnankk thanks for the reminder. Version is bumped

@craig-rueda
Copy link
Member

Looks like the linter still isn't happy

@Tonkonozhenko
Copy link
Author

@craig-rueda updated

@craig-rueda
Copy link
Member

Closing this as it duplicates #17252

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants