-
Notifications
You must be signed in to change notification settings - Fork 14.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(Dashboard): Handle undefined tab when collapsing tabs #17183
fix(Dashboard): Handle undefined tab when collapsing tabs #17183
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Added non-blocking comment, other than that lgtm!
Codecov Report
@@ Coverage Diff @@
## master #17183 +/- ##
==========================================
- Coverage 76.91% 76.91% -0.01%
==========================================
Files 1039 1039
Lines 55568 55568
Branches 7570 7571 +1
==========================================
- Hits 42742 42741 -1
- Misses 12576 12577 +1
Partials 250 250
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
/testenv up |
@geido Ephemeral environment spinning up at http://52.33.222.248:8080. Credentials are |
Ephemeral environment shutdown and build artifacts deleted. |
🏷 2021.42 |
(cherry picked from commit 91199c3)
(cherry picked from commit 91199c3)
SUMMARY
It handles collapsing tabs when there is no tab left.
BEFORE
Fixes #17180
AFTER
untitled.dashb.mp4
TESTING INSTRUCTIONS
ADDITIONAL INFORMATION