Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(Dashboard): Handle undefined tab when collapsing tabs #17183

Merged
merged 1 commit into from
Oct 21, 2021
Merged

fix(Dashboard): Handle undefined tab when collapsing tabs #17183

merged 1 commit into from
Oct 21, 2021

Conversation

geido
Copy link
Member

@geido geido commented Oct 21, 2021

SUMMARY

It handles collapsing tabs when there is no tab left.

BEFORE

Fixes #17180

AFTER

untitled.dashb.mp4

TESTING INSTRUCTIONS

  1. Edit a Dashboard
  2. Add a tab component
  3. Delete all tabs and collapse

ADDITIONAL INFORMATION

Copy link
Member

@kgabryje kgabryje left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added non-blocking comment, other than that lgtm!

@codecov
Copy link

codecov bot commented Oct 21, 2021

Codecov Report

Merging #17183 (d7df66e) into master (4c708af) will decrease coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #17183      +/-   ##
==========================================
- Coverage   76.91%   76.91%   -0.01%     
==========================================
  Files        1039     1039              
  Lines       55568    55568              
  Branches     7570     7571       +1     
==========================================
- Hits        42742    42741       -1     
- Misses      12576    12577       +1     
  Partials      250      250              
Flag Coverage Δ
javascript 70.93% <100.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...d/src/dashboard/util/getLeafComponentIdFromPath.js 100.00% <100.00%> (ø)
...eFilters/FiltersConfigModal/FiltersConfigModal.tsx 86.90% <0.00%> (-0.60%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4c708af...d7df66e. Read the comment docs.

@geido
Copy link
Member Author

geido commented Oct 21, 2021

/testenv up

@github-actions
Copy link
Contributor

@geido Ephemeral environment spinning up at http://52.33.222.248:8080. Credentials are admin/admin. Please allow several minutes for bootstrapping and startup.

@geido geido merged commit 91199c3 into apache:master Oct 21, 2021
@github-actions
Copy link
Contributor

Ephemeral environment shutdown and build artifacts deleted.

@rosemarie-chiu
Copy link
Contributor

🏷 2021.42

rosemarie-chiu pushed a commit to preset-io/superset that referenced this pull request Oct 22, 2021
(cherry picked from commit 91199c3)
opus-42 pushed a commit to opus-42/incubator-superset that referenced this pull request Nov 14, 2021
@rusackas rusackas added the v1.4 label Dec 3, 2021
eschutho pushed a commit that referenced this pull request Dec 6, 2021
(cherry picked from commit 91199c3)
@mistercrunch mistercrunch added 🍒 1.4.0 🍒 1.4.1 🍒 1.4.2 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 1.5.0 labels Mar 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels preset:2021.42 size/XS v1.4 🍒 1.4.0 🍒 1.4.1 🍒 1.4.2 🚢 1.5.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[dashboard edit] unexpected error appears when user tries to collapse tab content
5 participants