fix: sql lab crash caused by invalid template #17133
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
If user has invalid template in the query and run the query, SQL Lab will crash.
The error returned from backend seems not compatible with front-end error handle logic.
Front-end is expecting an
extra
object and has a list ofissue_codes
in extra object. but currentlyerror
contains single error message.This PR is only a short solution in the frontend to handle JS error in the current format, so that our sql lab users won't be blocked by simple syntax error. The root cause of the problem need further refactor work.
BEFORE/AFTER SCREENSHOTS OR
Before: SQL Lab page is blank
After:
TESTING INSTRUCTIONS
CI and manual test
ADDITIONAL INFORMATION
cc @etr2460 @ofekisr