Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: remove redundant po2json dev dependency #17129

Merged
merged 1 commit into from
Oct 15, 2021

Conversation

villebro
Copy link
Member

@villebro villebro commented Oct 15, 2021

SUMMARY

While checking licenses with license-checker on superset-frontend, I noticed we have an LGPL licensed dev dependency po2json, which is not compliant with Apache license policies. Since po2json package is not being used in either CI or npm scripts, and is only referred to in the contributing guide where users are instructed to globally install the package when translating JS files, the package isn't really needed as a dev dependency.

AFTER

The list doesn't contain any (L)GPL licensed packages:

$ license-checker --summary
├─ MIT: 2076
├─ ISC: 159
├─ BSD-3-Clause: 95
├─ Apache-2.0: 89
├─ BSD-2-Clause: 57
├─ MIT*: 6
├─ CC0-1.0: 5
├─ BSD*: 4
├─ BSD: 4
├─ Unlicense: 3
├─ 0BSD: 3
├─ (MIT OR CC0-1.0): 3
├─ CC-BY-4.0: 2
├─ WTFPL: 2
├─ Custom: https://github.com/tmcw/jsonlint: 1
├─ (Unlicense OR Apache-2.0): 1
├─ (MIT OR Apache-2.0): 1
├─ MPL-2.0: 1
├─ Custom: https://github.com/saikocat/colorbrewer.: 1
├─ Apache-Style: 1
├─ (MPL-2.0 OR Apache-2.0): 1
├─ Apache*: 1
├─ AFLv2.1,BSD: 1
├─ ODC-By-1.0: 1
├─ Apache-2.0 WITH LLVM-exception: 1
├─ (BSD-3-Clause OR GPL-2.0): 1
├─ (WTFPL OR MIT): 1
├─ (MIT AND Zlib): 1
├─ (MIT AND BSD-3-Clause): 1
├─ CC-BY-3.0: 1
├─ (MIT OR GPL-3.0): 1
└─ Public Domain: 1

BEFORE

See the reference to "GNU Library General Public License":

$ license-checker --summary
├─ MIT: 2082
├─ ISC: 159
├─ BSD-3-Clause: 95
├─ Apache-2.0: 89
├─ BSD-2-Clause: 57
├─ MIT*: 7
├─ CC0-1.0: 5
├─ BSD*: 4
├─ BSD: 4
├─ Unlicense: 3
├─ 0BSD: 3
├─ (MIT OR CC0-1.0): 3
├─ CC-BY-4.0: 2
├─ WTFPL: 2
├─ Custom: https://github.com/tmcw/jsonlint: 1
├─ (Unlicense OR Apache-2.0): 1
├─ (MIT OR Apache-2.0): 1
├─ MPL-2.0: 1
├─ Custom: https://github.com/saikocat/colorbrewer.: 1
├─ Apache-Style: 1
├─ (MPL-2.0 OR Apache-2.0): 1
├─ Apache*: 1
├─ AFLv2.1,BSD: 1
├─ ODC-By-1.0: 1
├─ Apache-2.0 WITH LLVM-exception: 1
├─ (BSD-3-Clause OR GPL-2.0): 1
├─ (WTFPL OR MIT): 1
├─ (MIT AND Zlib): 1
├─ GNU Library General Public License: 1
├─ (MIT AND BSD-3-Clause): 1
├─ CC-BY-3.0: 1
├─ (MIT OR GPL-3.0): 1
└─ Public Domain: 1

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

TESTING INSTRUCTIONS

ADDITIONAL INFORMATION

  • Has associated issue:
  • Required feature flags:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

Copy link
Member

@amitmiran137 amitmiran137 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@codecov
Copy link

codecov bot commented Oct 15, 2021

Codecov Report

Merging #17129 (c3dd2f4) into master (c9c669d) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master   #17129   +/-   ##
=======================================
  Coverage   76.94%   76.94%           
=======================================
  Files        1031     1031           
  Lines       55213    55213           
  Branches     7507     7507           
=======================================
  Hits        42483    42483           
  Misses      12480    12480           
  Partials      250      250           
Flag Coverage Δ
javascript 70.92% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.


Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c9c669d...c3dd2f4. Read the comment docs.

Copy link
Member

@kgabryje kgabryje left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Double checked to verify it's not used anywhere - no occurences in superset, superset-ui nor superset-ui-plugins-deckgl. LGTM

@villebro villebro merged commit e055e59 into apache:master Oct 15, 2021
@villebro villebro deleted the villebro/remove-po2json branch October 15, 2021 12:25
opus-42 pushed a commit to opus-42/incubator-superset that referenced this pull request Nov 14, 2021
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 1.5.0 labels Mar 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels preset-io size/XS 🚢 1.5.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants