fix: undefined error when anonymous user browses dashboards or charts

[wijnanjo]

SUMMARY

Prevent 'undefined' error when viewing the dashboard (or charts) listview in an anonymous mode.

TESTING INSTRUCTIONS

Reproduce the error as follows:

• Allow anonymous access by setting PUBLIC_ROLE_LIKE = "Gamma"
• Without logging in, click on dashboards or charts. This error displays:
  Unexpected error: TypeError: Cannot read properties of undefined (reading 'toString')

Cause: there's no null check on the userId variable.

ADDITIONAL INFORMATION

• Has associated issue:
• Required feature flags:
• Changes UI
• Includes DB Migration (follow approval process in SIP-59)
  • Migration is atomic, supports rollback & is backwards-compatible
  • Confirm DB migration upgrade and downgrade tested
  • Runtime estimates and downtime expectations provided
• Introduces new feature or API
• Removes existing feature or API

[pkdotson]

@wijnanjo can you please add before/after video of the fix.

[codecov]

Codecov Report

Merging #17117 (2a2fbdd) into master (d944503) will increase coverage by 0.00%.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##           master   #17117   +/-   ##
=======================================
  Coverage   76.86%   76.86%           
=======================================
  Files        1031     1031           
  Lines       55198    55198           
  Branches     7504     7506    +2     
=======================================
+ Hits        42428    42429    +1     
+ Misses      12520    12519    -1     
  Partials      250      250           

Flag	Coverage Δ
javascript	70.92% <100.00%> (+<0.01%)	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files	Coverage Δ
...perset-frontend/src/views/CRUD/chart/ChartList.tsx	74.35% <100.00%> (ø)
...rontend/src/views/CRUD/dashboard/DashboardList.tsx	72.22% <100.00%> (ø)
...eFilters/FiltersConfigModal/FiltersConfigModal.tsx	90.16% <0.00%> (+0.81%)	⬆️

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d944503...2a2fbdd. Read the comment docs.

[wijnanjo]

@pkdotson Here's a video showing before/after fix behavior:

[pkdotson]

LGTM! Thanks for the fix!