fix: error alert levels again #17027
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #17027 +/- ##
==========================================
- Coverage 76.93% 76.89% -0.05%
==========================================
Files 1030 1031 +1
Lines 55088 55182 +94
Branches 7480 7505 +25
==========================================
+ Hits 42383 42431 +48
- Misses 12454 12499 +45
- Partials 251 252 +1
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
|
This is verified in our env, so ready for a stamp |
villebro
approved these changes
Oct 11, 2021
| {!level || level === 'error' ? ( | ||
| <Icons.ErrorSolid iconColor={theme.colors.error.base} /> | ||
| {level === 'error' ? ( | ||
| <Icons.ErrorSolid iconColor={theme.colors[level].base} /> |
There was a problem hiding this comment.
To avoid duplication, could we create const iconColor = theme.colors[level].base above and then reference that here and below?
| <Icons.ErrorSolid | ||
| className="icon" | ||
| iconColor={theme.colors.error.base} | ||
| iconColor={theme.colors[level].base} |
etr2460
force-pushed
the
erik-ritter--fix-error-alerts-again
branch
from
0cec291 to
3fb15e6
Compare
eschutho
pushed a commit
to preset-io/superset
that referenced
this pull request
Oct 27, 2021
opus-42
pushed a commit
to opus-42/incubator-superset
that referenced
this pull request
Nov 14, 2021
QAlexBall
pushed a commit
to QAlexBall/superset
that referenced
this pull request
Dec 28, 2021
mistercrunch
added
🍒 1.4.0
🍒 1.4.1
🍒 1.4.2
🏷️ bot
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
Even after these fixes, and apparently because this doesn't repro well in the testenv, there were still issues with my previous fix because we use
levelin the styled components (which i missed the first 2 times here).I'm going to cherrypick this fix into our deploy before merging this PR this time, since i've failed to fix this twice already
BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
TESTING INSTRUCTIONS
CI, deploy to our internal env for repro
ADDITIONAL INFORMATION
to: @rusackas @graceguo-supercat @michael-s-molina