Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: no direct use of supersetTheme (or bad LESS vars) in SqlEditor #16999

Merged
merged 3 commits into from
Oct 7, 2021
Merged

chore: no direct use of supersetTheme (or bad LESS vars) in SqlEditor #16999

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
5341b11
chore: no direct use of supersetTheme (or bad LESS vars) in SqlEditor
rusackas Oct 7, 2021
a9cda6d
putting the background back in, but using the theme.
rusackas Oct 7, 2021
d5c4302
should be no need for this import anymore.
rusackas Oct 7, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions superset-frontend/src/SqlLab/components/SqlEditor/index.jsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,7 @@ import { connect } from 'react-redux';
import { bindActionCreators } from 'redux';
import PropTypes from 'prop-types';
import Split from 'react-split';
import { t, styled, supersetTheme, withTheme } from '@superset-ui/core';
import { t, styled, withTheme } from '@superset-ui/core';
import debounce from 'lodash/debounce';
import throttle from 'lodash/throttle';
import StyledModal from 'src/components/Modal';
Expand Down Expand Up @@ -102,10 +102,10 @@ const LimitSelectStyled = styled.span`

const StyledToolbar = styled.div`
padding: ${({ theme }) => theme.gridUnit * 2}px;
background-color: @lightest;
background: ${({ theme }) => theme.colors.grayscale.light5};
display: flex;
justify-content: space-between;
border: 1px solid ${supersetTheme.colors.grayscale.light2};
border: 1px solid ${({ theme }) => theme.colors.grayscale.light2};
border-top: 0;

form {
Expand Down