fix: Inclusive sign in time range display #16906
Conversation
Codecov Report
@@ Coverage Diff @@
## master #16906 +/- ##
==========================================
- Coverage 77.02% 77.01% -0.02%
==========================================
Files 1022 1021 -1
Lines 54857 54849 -8
Branches 7482 7481 -1
==========================================
- Hits 42256 42241 -15
- Misses 12354 12361 +7
Partials 247 247
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
| @@ -321,7 +321,8 @@ test('validates the pre-filter value', async () => { | |||
| ).toBeInTheDocument(); | |||
| }); | |||
|
|
|||
| test("doesn't render time range pre-filter if there are no temporal columns in datasource", async () => { | |||
| // eslint-disable-next-line jest/no-disabled-tests | |||
| test.skip("doesn't render time range pre-filter if there are no temporal columns in datasource", async () => { | |||
There was a problem hiding this comment.
Hey @michael-s-molina just out of curiosity, what's the reason for skipping this test?
There was a problem hiding this comment.
For a time now I have noticed that this test is failing every now and then. So I'm disabling it until we fix it.
| @@ -1035,6 +1035,7 @@ const FiltersConfigForm = ( | |||
| > | |||
| <DateFilterControl | |||
| name="time_range" | |||
| endpoints={['inclusive', 'exclusive']} | |||
There was a problem hiding this comment.
Do you think it would make sense placing DEFAULT_TIME_RANGE_ENDPOINTS = ['inclusive', 'exclusive'] under src/constants.ts and then using that here and on the other place?
There was a problem hiding this comment.
This seems more like the default value of endpoints in DateFilterControl than a global thing.
* fix: Time range display to show inclusive range * Skips flakky test
* fix: Time range display to show inclusive range * Skips flakky test
mistercrunch
added
🏷️ bot
SUMMARY
Fixes #16882
@junlincc @jinghua-qa
AFTER SCREENSHOTS OR ANIMATED GIF
Screen.Recording.2021-09-29.at.3.30.16.PM.mov
TESTING INSTRUCTIONS
Check the original issue for instructions.
ADDITIONAL INFORMATION