Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Updates the selected values when changing the native filter type, column or default value #16833

Merged
merged 1 commit into from
Sep 24, 2021

Conversation

michael-s-molina
Copy link
Member

SUMMARY

Fixes #16813

@junlincc @jinghua-qa

AFTER VIDEO

Screen.Recording.2021-09-24.at.11.58.21.AM.mov

TESTING INSTRUCTIONS

Check the original issue for instructions.

ADDITIONAL INFORMATION

  • Has associated issue:
  • Required feature flags:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

@codecov
Copy link

codecov bot commented Sep 24, 2021

Codecov Report

Merging #16833 (0a45591) into master (4086bed) will increase coverage by 0.02%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #16833      +/-   ##
==========================================
+ Coverage   77.00%   77.02%   +0.02%     
==========================================
  Files        1018     1018              
  Lines       54654    54669      +15     
  Branches     7454     7460       +6     
==========================================
+ Hits        42086    42109      +23     
+ Misses      12324    12316       -8     
  Partials      244      244              
Flag Coverage Δ
javascript 71.13% <100.00%> (+0.04%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
superset-frontend/src/dataMask/reducer.ts 71.15% <ø> (+5.76%) ⬆️
...board/components/nativeFilters/FilterBar/index.tsx 88.37% <100.00%> (+2.04%) ⬆️
superset-frontend/src/dataMask/actions.ts 72.22% <100.00%> (+33.33%) ⬆️
...hboard/components/nativeFilters/FilterBar/utils.ts 71.87% <0.00%> (-3.13%) ⬇️
...src/components/FilterableTable/FilterableTable.tsx 81.86% <0.00%> (-0.32%) ⬇️
...perset-frontend/src/views/CRUD/chart/ChartList.tsx 74.35% <0.00%> (ø)
...rontend/src/views/CRUD/dashboard/DashboardList.tsx 72.22% <0.00%> (ø)
...ontend/src/views/CRUD/data/dataset/DatasetList.tsx 65.92% <0.00%> (ø)
.../src/views/CRUD/data/savedquery/SavedQueryList.tsx 73.10% <0.00%> (+0.18%) ⬆️
... and 1 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4086bed...0a45591. Read the comment docs.

@michael-s-molina
Copy link
Member Author

/testenv up FEATURE_DASHBOARD_NATIVE_FILTERS=true

@github-actions
Copy link
Contributor

@michael-s-molina Ephemeral environment spinning up at http://34.216.17.97:8080. Credentials are admin/admin. Please allow several minutes for bootstrapping and startup.

Copy link
Member

@geido geido left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks for the fix!

Copy link
Member

@jinghua-qa jinghua-qa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@michael-s-molina michael-s-molina merged commit 1ff682f into apache:master Sep 24, 2021
@github-actions
Copy link
Contributor

Ephemeral environment shutdown and build artifacts deleted.

@sadpandajoe
Copy link
Member

🏷️ 2021.38

stevenuray pushed a commit to preset-io/superset that referenced this pull request Sep 27, 2021
…, column or default value (apache#16833)

(cherry picked from commit 1ff682f)
opus-42 pushed a commit to opus-42/incubator-superset that referenced this pull request Nov 14, 2021
QAlexBall pushed a commit to QAlexBall/superset that referenced this pull request Dec 28, 2021
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 1.4.0 labels Mar 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels preset:2021.38 size/M 🚢 1.4.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Native Filter] change filter column did not update the column value on dashboard
5 participants