-
Notifications
You must be signed in to change notification settings - Fork 14.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Updates the selected values when changing the native filter type, column or default value #16833
Conversation
…, column or default value
Codecov Report
@@ Coverage Diff @@
## master #16833 +/- ##
==========================================
+ Coverage 77.00% 77.02% +0.02%
==========================================
Files 1018 1018
Lines 54654 54669 +15
Branches 7454 7460 +6
==========================================
+ Hits 42086 42109 +23
+ Misses 12324 12316 -8
Partials 244 244
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
/testenv up FEATURE_DASHBOARD_NATIVE_FILTERS=true |
@michael-s-molina Ephemeral environment spinning up at http://34.216.17.97:8080. Credentials are |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Thanks for the fix!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Ephemeral environment shutdown and build artifacts deleted. |
🏷️ 2021.38 |
…, column or default value (apache#16833) (cherry picked from commit 1ff682f)
…, column or default value (apache#16833)
…, column or default value (apache#16833)
SUMMARY
Fixes #16813
@junlincc @jinghua-qa
AFTER VIDEO
Screen.Recording.2021-09-24.at.11.58.21.AM.mov
TESTING INSTRUCTIONS
Check the original issue for instructions.
ADDITIONAL INFORMATION