-
Notifications
You must be signed in to change notification settings - Fork 14.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Bulk update Spanish translations #16799
Conversation
Codecov Report
@@ Coverage Diff @@
## master #16799 +/- ##
==========================================
- Coverage 76.92% 76.78% -0.14%
==========================================
Files 1048 1048
Lines 56514 56514
Branches 7805 7805
==========================================
- Hits 43474 43397 -77
- Misses 12786 12863 +77
Partials 254 254
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Dropped a bunch of comments for the first 1/3 or so of the file. Mostly nits or small syntax/grammar corrections
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Second pass for the rest of the file. Many nits, grammar, spelling, and syntax fixes. Hope this helps!
|
||
#: superset/views/database/forms.py:130 superset/views/database/forms.py:321 | ||
msgid "Table Exists" | ||
msgstr "" | ||
msgstr "Tabla Existe" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
msgstr "Tabla Existe" | |
msgstr "La Tabla Existe" |
@@ -2879,19 +2885,19 @@ msgstr "" | |||
|
|||
#: superset/views/database/forms.py:137 superset/views/database/forms.py:328 | |||
msgid "Fail" | |||
msgstr "" | |||
msgstr "Falla" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
msgstr "Falla" | |
msgstr "Fallido" |
|
||
#: superset/views/database/forms.py:138 superset/views/database/forms.py:329 | ||
msgid "Replace" | ||
msgstr "" | ||
msgstr "Remplazar" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
msgstr "Remplazar" | |
msgstr "Reemplazar" |
@@ -2911,79 +2917,79 @@ msgstr "" | |||
|
|||
#: superset/views/database/forms.py:163 superset/views/database/forms.py:354 | |||
msgid "Mangle Duplicate Columns" | |||
msgstr "" | |||
msgstr "Manglar Columnas Duplicadas" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This one is tricky - AFAIK there's nothing such as mangling in Spanish (a "manglar" is a mango tree orchard lol). The closest one I can think of reads as "Decorate name for duplicated values".
msgstr "Manglar Columnas Duplicadas" | |
msgstr "Decorar Nombre de Columnas Duplicadas" |
|
||
#: superset/views/database/forms.py:182 | ||
msgid "Skip Blank Lines" | ||
msgstr "" | ||
msgstr "Saltar líneas vacías" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
msgstr "Saltar líneas vacías" | |
msgstr "Omitir líneas vacías" |
|
||
#: superset-frontend/src/visualizations/FilterBox/controlPanel.jsx:83 | ||
msgid "Check to include time column dropdown" | ||
msgstr "Mostrar un filtro de tiempo" | ||
msgstr "Marcar para incluir la columna de tiempo en la caja de selección" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
msgstr "Marcar para incluir la columna de tiempo en la caja de selección" | |
msgstr "Marcar para incluir la lista desplegable de tiempo de la columna" |
|
||
#: superset-frontend/src/visualizations/FilterBox/controlPanel.jsx:92 | ||
msgid "Show Druid granularity dropdown" | ||
msgstr "" | ||
msgstr "Mostrar caja de selección de Granularidad de Druid" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
msgstr "Mostrar caja de selección de Granularidad de Druid" | |
msgstr "Mostrar lista desplegable de granularidad de Druid" |
|
||
#: superset-frontend/src/visualizations/FilterBox/controlPanel.jsx:94 | ||
msgid "Check to include Druid granularity dropdown" | ||
msgstr "" | ||
msgstr "Marcar para incluir la caja de selección de Granularidad de Druid" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
msgstr "Marcar para incluir la caja de selección de Granularidad de Druid" | |
msgstr "Marcar para incluir la lista desplegable de granularidad de Druid" |
|
||
#: superset-frontend/src/visualizations/FilterBox/controlPanel.jsx:103 | ||
msgid "Check to include time origin dropdown" | ||
msgstr "Mostrar un filtro de tiempo" | ||
msgstr "Marcar para incluir la caja de selección de origen de tiempo" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
msgstr "Marcar para incluir la caja de selección de origen de tiempo" | |
msgstr "Marcar para incluir la lista desplegable de origen de tiempo" |
|
||
#: superset-frontend/src/visualizations/FilterBox/controlPanel.jsx:114 | ||
msgid "These filters apply to the values available in the dropdowns" | ||
msgstr "" | ||
msgstr "Estos filtros aplican para los valores disponibles en la caja de selección" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
msgstr "Estos filtros aplican para los valores disponibles en la caja de selección" | |
msgstr "Estos filtros son aplicados a los valores disponibles en la lista desplegable" |
Thanks @diegomgomez! It seems that the file diff is too large to load and I can't bulk add your suggestions from within Github. Can you create a commit including all your suggestions? I added you as collaborator to my fork, so you won't need to create your own. |
No, sorry. It's a burden that Github apparently doesn't allow you to bulk accept suggestions, but at this point it'd be too much (and repated) work for me to create a branch and re-make all the changes than to accept them from the current branch. It'd also be advisable that you take a quick look over my changes to make sure you agree with them, which should blend in with the suggestion acceptance process. |
Thanks @dreglad and @diegomgomez for the hard work here! This PR is in a conflicted state; can you please rebase it so we can get it merged? If you both agree this PR leaves the translation in a better state than before, I'm happy to merge this and welcome incremental improvements in follow-up PRs. |
@dreglad if needed I can rebase the PR, but since I don't speak Spanish I may introduce errors in the translations, hence it may be better if one you could help push this across the finish line |
a556dd8
to
0f10e1d
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks for the hard work!
* Bulk update Spanish translations * Update Spanish translations * Apply Spanish translations suggestions from code review Co-authored-by: Diego M. Gómez <[email protected]> * convert json file Co-authored-by: Diego M. Gómez <[email protected]> Co-authored-by: Ville Brofeldt <[email protected]>
fix(translation): Update Spanish translations
SUMMARY
Spanish translations were largely updated including many of them that were dangerously inaccurate or incorrect, such like translating "delete" as indeed the opposite "create" which obviously would be catastrophic in many situations.
TESTING INSTRUCTIONS
The Spanish language has many linguistic variants depending on factors such as geographic region. These translations aim to be as neutral as possible. It might be still far from perfect, however there were largely incomplete and many of them severely inaccurate (even translating to the exact opposite meaning!)
ADDITIONAL INFORMATION