Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Update documentation on schema changes #16784

Merged
merged 1 commit into from
Sep 23, 2021

Conversation

frafra
Copy link
Contributor

@frafra frafra commented Sep 22, 2021

Fix(documentation): sync columns from source.
Fix: #16785

SUMMARY

FAQ is outdated and there is a similar question asked twice. I dropped the latter and fixed the first.

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

TESTING INSTRUCTIONS

ADDITIONAL INFORMATION

  • Has associated issue: [docs_update]FAQ on schema change is outdated #16785
  • Required feature flags:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

@junlincc junlincc changed the title Update documentation on schema changes chore: Update documentation on schema changes Sep 22, 2021
Copy link
Member

@junlincc junlincc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for the. contribution! We have a template for PR naming, it will be even better if you can adopt the template in your next contribution :), i have changed your title to start the checks. also link your open issue to the PR, so when the PR is merged, issue will be closed automatically.

@zhaoyongjie take an another look to make sure everything is captured by the update? 🙏

@zhaoyongjie zhaoyongjie self-requested a review September 23, 2021 04:20
Copy link
Member

@zhaoyongjie zhaoyongjie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the contributions

@zhaoyongjie zhaoyongjie merged commit 997320a into apache:master Sep 23, 2021
@frafra frafra deleted the patch-1 branch September 23, 2021 06:16
@frafra
Copy link
Contributor Author

frafra commented Sep 23, 2021

I will follow the rules for PR naming in the future! Thanks for your help :)

opus-42 pushed a commit to opus-42/incubator-superset that referenced this pull request Nov 14, 2021
QAlexBall pushed a commit to QAlexBall/superset that referenced this pull request Dec 28, 2021
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 1.4.0 labels Mar 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels size/S 🚢 1.4.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[docs_update]FAQ on schema change is outdated
5 participants