Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: add browser info to template #16732

Merged
merged 2 commits into from
Sep 21, 2021
Merged

chore: add browser info to template #16732

merged 2 commits into from
Sep 21, 2021

Conversation

junlincc
Copy link
Member

SUMMARY

We have been seeing some browser specific issues lately from component migration work. A regression that's seen in firefox may not be found in chrome, which is what we use for testing mainly. It's helpful for us to understand what browser user uses when bugs occur.

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

NA

TESTING INSTRUCTIONS

NA

ADDITIONAL INFORMATION

  • Has associated issue:
  • Required feature flags:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

issue report with browser info
@codecov
Copy link

codecov bot commented Sep 17, 2021

Codecov Report

Merging #16732 (028d159) into master (7586e47) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master   #16732   +/-   ##
=======================================
  Coverage   76.98%   76.98%           
=======================================
  Files        1007     1007           
  Lines       54174    54174           
  Branches     7463     7463           
=======================================
  Hits        41708    41708           
  Misses      12226    12226           
  Partials      240      240           
Flag Coverage Δ
hive 81.31% <ø> (-0.04%) ⬇️
javascript 71.30% <ø> (ø)
mysql 81.69% <ø> (ø)
postgres 81.79% <ø> (ø)
presto 81.69% <ø> (+0.03%) ⬆️
python 82.31% <ø> (ø)
sqlite 81.37% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.


Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7586e47...028d159. Read the comment docs.

@junlincc junlincc changed the title chore(template): add browser info to template chore: add browser info to template Sep 17, 2021
@zhaoyongjie zhaoyongjie self-requested a review September 21, 2021 00:23
@zhaoyongjie zhaoyongjie merged commit a8d5342 into master Sep 21, 2021
opus-42 pushed a commit to opus-42/incubator-superset that referenced this pull request Nov 14, 2021
* add browser info to template

issue report with browser info

* Update .github/ISSUE_TEMPLATE/bug_report.md

Co-authored-by: Yongjie Zhao <[email protected]>

Co-authored-by: Yongjie Zhao <[email protected]>
QAlexBall pushed a commit to QAlexBall/superset that referenced this pull request Dec 28, 2021
* add browser info to template

issue report with browser info

* Update .github/ISSUE_TEMPLATE/bug_report.md

Co-authored-by: Yongjie Zhao <[email protected]>

Co-authored-by: Yongjie Zhao <[email protected]>
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 1.4.0 labels Mar 13, 2024
@mistercrunch mistercrunch deleted the browser_info branch March 26, 2024 16:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels size/XS 🚢 1.4.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants