-
Notifications
You must be signed in to change notification settings - Fork 14.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
perf(dashboard): native filter select will be stuck if there has a filter box. #16702
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Thanks for the fix
Codecov Report
@@ Coverage Diff @@
## master #16702 +/- ##
==========================================
- Coverage 76.93% 76.92% -0.01%
==========================================
Files 1007 1007
Lines 54117 54121 +4
Branches 7348 7351 +3
==========================================
Hits 41634 41634
- Misses 12243 12247 +4
Partials 240 240
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM - nice catch!
(cherry picked from commit b0ac5d1)
SUMMARY
This PR fixes the case that if the dashboard has a filterbox, native filter select will be very stuck.
BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
before
2021-09-14.10.34.17.mov
after
2021-09-14.10.35.57.mov
TESTING INSTRUCTIONS
ADDITIONAL INFORMATION