-
Notifications
You must be signed in to change notification settings - Fork 14.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Tabs in column #16593
feat: Tabs in column #16593
Conversation
� Conflicts: � superset-frontend/src/dashboard/util/getPermissions.ts
Codecov Report
@@ Coverage Diff @@
## master #16593 +/- ##
==========================================
+ Coverage 76.71% 76.83% +0.12%
==========================================
Files 1002 1004 +2
Lines 53780 53902 +122
Branches 6859 7339 +480
==========================================
+ Hits 41255 41416 +161
+ Misses 12288 12246 -42
- Partials 237 240 +3
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I am looking forward to the feature.
Tested in the local environment
- can't change all of tab title
- can't close the delete modal
https://user-images.githubusercontent.com/2016594/132463507-6626b7dc-b9b3-49bb-b301-8d1216343455.mov
@zhaoyongjie thanks for review I fixed bugs that you found :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested in my local environment and codes LGTM. I am looking forward to this feature.
Thanks for the contribution! we should have it highlighted in next release |
* fix:fix get permission function * feat: add tabs inside column * lint: fix lint * test: fix test * test: fix tests * test: fix tests * fix: pass onChangeTab function through layout
* fix:fix get permission function * feat: add tabs inside column * lint: fix lint * test: fix test * test: fix tests * test: fix tests * fix: pass onChangeTab function through layout
SUMMARY
This PR add possibility to add
Tabs
layout element toColumn
tab elementScreen.Recording.2021-09-05.at.0.17.26.mov
BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
TESTING INSTRUCTIONS
ADDITIONAL INFORMATION