Added filter in ControlPanelsContainer for explore V2 #1647
Conversation
vera-liu
force-pushed
the
vliu_filter
branch
from
3a11f6a to
ecd45cc
Compare
| // only display filters with current prefix | ||
| if (filter.prefix === this.props.prefix) { | ||
| filters.push( | ||
| <div> |
There was a problem hiding this comment.
could we pull this out into it's own SFC?
| }); | ||
| } | ||
| /* eslint no-param-reassign: 0 */ | ||
| delete form_data[`${prefix}_col_${i}`]; |
There was a problem hiding this comment.
I store and deal with filters in store as arrays since it's cleaner, in the form_data passed in it has arbitrary number of flt_eq/op/col as params, if we don't delete them they will linger in store and passed back again in onQuery.
| return filters; | ||
| }; | ||
|
|
||
| const getFilters = function (form_data, datasource_type) { |
There was a problem hiding this comment.
our style guide calls for named functions:
function getFilters(form_data, datasource_type) {
...
}There was a problem hiding this comment.
| }, | ||
| { | ||
| label: 'Result Filters', | ||
| description: 'Filters are defined using comma delimited strings as in <US,FR,Other>' + |
There was a problem hiding this comment.
is Result Filters supposed to have the same description as Filters?
| // Todo: remove after launch | ||
| data.V2 = true; | ||
| data.datasource_id = form_data.datasource; | ||
| data.datasource_type = datasource_type; |
There was a problem hiding this comment.
could simplify this to:
const data = {
datasource_type,
datasource_id: form_data.datasource,
V2: true, // todo: remove after launch, V2 tag temporarily for updating url
};
| @@ -7,6 +7,7 @@ import { Panel, Alert } from 'react-bootstrap'; | |||
| import { visTypes, commonControlPanelSections } from '../stores/store'; | |||
| import ControlPanelSection from './ControlPanelSection'; | |||
| import FieldSetRow from './FieldSetRow'; | |||
| import Filters from './Filters'; | |||
There was a problem hiding this comment.
do we have a test for this component? if not in this PR, would probably be beneficial to add.
vera-liu
force-pushed
the
vliu_filter
branch
3 times, most recently
from
0c70a9c to
7d9308f
Compare
vera-liu
force-pushed
the
vliu_filter
branch
2 times, most recently
from
603c3c5 to
e1172b3
Compare
vera-liu
force-pushed
the
vliu_filter
branch
from
e1172b3 to
da104ae
Compare
mistercrunch
added
🏷️ bot
Done:
Todo:
needs-review @ascott @mistercrunch