Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Add new dev commands to Makefile #16327

Merged
merged 2 commits into from
Aug 20, 2021
Merged

feat: Add new dev commands to Makefile #16327

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
e2f4440
updating makefile
hughhhh Aug 18, 2021
9f11039
Update Makefile
hughhhh Aug 18, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 7 additions & 1 deletion Makefile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -58,7 +58,7 @@ update-py:

update-js:
# Install js packages
cd superset-frontend; npm install
cd superset-frontend; npm ci
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A suggestion; instead of using cd do this:

Suggested change
cd superset-frontend; npm ci
pushd superset-frontend; npm ci; popd

This will bring back the user to the directory they were when they ran the command.


venv:
# Create a virtual environment and activate it (recommended)
Expand All @@ -81,3 +81,9 @@ py-lint: pre-commit

js-format:
cd superset-frontend; npm run prettier
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same here.


flask-app:
flask run -p 8088 --with-threads --reload --debugger

node-app:
cd superset-frontend; npm run dev-server
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

And here.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Running the command you still land in the root just tested it locally so we don't need to change it