refactor: external metadata fetch API #16193
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #16193 +/- ##
==========================================
- Coverage 76.75% 76.71% -0.05%
==========================================
Files 996 997 +1
Lines 53054 53073 +19
Branches 6760 6740 -20
==========================================
- Hits 40721 40714 -7
- Misses 12107 12130 +23
- Partials 226 229 +3
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
villebro
reviewed
Aug 13, 2021
Comment on lines
+498
to
+500
| Object.keys(params).map(key => | ||
| params[key] === undefined ? null : params[key], | ||
| ), |
There was a problem hiding this comment.
Don't we need to encode the key/value pairs (Object.entries), not just the values (Object.keys)? (honest question, I haven't done a lot of this rison API stuff)
There was a problem hiding this comment.
this is to code entire params field, just change undefined to null, because prison can't encode undefined value
villebro
approved these changes
Aug 13, 2021
amitmiran137
pushed a commit
that referenced
this pull request
Aug 16, 2021
…gies * upstream/master: (64 commits) check roles before fetching reports (#16260) chore: upgrade mypy and add type guards (#16227) fix: pivot columns with ints for name (#16259) chore(pylint): Bump Pylint to 2.9.6 (#16146) fix examples tab for dashboard (#16253) chore: bump superset-ui packages to 0.17.84 (#16251) chore: Shows the dataset description in the gallery dropdown (#16200) fix(Dashboard): Omnibar dropdown visibility and keyboard commands (#16168) chore: bump py version for integration test (#16213) fix: skip perms on query context update (#16250) refactor: external metadata fetch API (#16193) feat(dao): admin can remove self from object owners (#15149) fix(dashboard): cross filter chart highlight when filters badge icon clicked (#16233) fix: validate_parameters and query (#16241) fix: Remove Advanced Analytics tag for 2 charts (#16240) Revert "feat: Changing Dataset names (#16199)" (#16235) feat: Allow users to connect via legacy SQLA form (#16201) fix: remove encryption from db params (#16214) fix(Explore): Show the tooltip only when label does not fit the container in METRICS/FILTERS/GROUP BY/SORT BY of the DATA panel (#16060) Show/hide tooltips (#16192) ... # Conflicts: # superset/tasks/caching/cache_strategy.py
9 tasks
john-bodley
reviewed
Aug 23, 2021
| from typing_extensions import TypedDict | ||
|
|
||
|
|
||
| class ExternalMetadataParams(TypedDict): |
There was a problem hiding this comment.
@villebro @zhaoyongjie I wonder if we should be using marshmallow_dataclass instead as it adhere's to the DRY principle and simplifies the code. I've used it for an internal project and I'm definitely a fan.
There was a problem hiding this comment.
Thanks for the mention. It's a more elegant way, let me try to use marshmallow_dataclass to refactor this class.
villebro
pushed a commit
that referenced
this pull request
Sep 6, 2021
* refactor: external metadata api * fix comments * fix ut * fix fe lint * fix UT * fix UT (cherry picked from commit 6cd15d5)
opus-42
pushed a commit
to opus-42/incubator-superset
that referenced
this pull request
Nov 14, 2021
* refactor: external metadata api * fix comments * fix ut * fix fe lint * fix UT * fix UT
QAlexBall
pushed a commit
to QAlexBall/superset
that referenced
this pull request
Dec 28, 2021
* refactor: external metadata api * fix comments * fix ut * fix fe lint * fix UT * fix UT
mistercrunch
added
🍒 1.3.1
🍒 1.3.2
🏷️ bot
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
closes: #16172
When special characters("/") are encountered, the API
/datasource/external_metadata_by_name/<datasouce_type>/<database_name>/<schema_name>/<table_name>cannot be called.This PR refactor this API to
/datasource/external_metadata_by_name/?q=<rison string>BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
After
virtual_dataset_sync.mov
TESTING INSTRUCTIONS
ADDITIONAL INFORMATION