-
Notifications
You must be signed in to change notification settings - Fork 14.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Hide Safari default tooltip #16145
Conversation
Codecov Report
@@ Coverage Diff @@
## master #16145 +/- ##
=======================================
Coverage 76.83% 76.84%
=======================================
Files 995 995
Lines 52884 52885 +1
Branches 6721 6721
=======================================
+ Hits 40636 40640 +4
+ Misses 12023 12020 -3
Partials 225 225
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
/testenv up |
@geido Ephemeral environment spinning up at http://34.214.104.103:8080. Credentials are |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Thanks for the fix!
SUMMARY
This PR implements a small hack to prevent Safari from showing its default tooltip when a text is truncated and a custom Antdesign tooltip is already present.
RELATED PR ON SUPERSET-UI
apache-superset/superset-ui#1283
BEFORE
AFTER
ADDITIONAL INFORMATION