feat: add profiling to Superset pages #16136
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
betodealmeida
commented
Aug 8, 2021
superset/app.py
Outdated
| @@ -36,6 +37,10 @@ def create_app() -> Flask: | |||
| app_initializer = app.config.get("APP_INITIALIZER", SupersetAppInitializer)(app) | |||
| app_initializer.init_app() | |||
|
|
|||
| profiling = app.config.get("PROFILING", False) | |||
| if profiling: | |||
| app.wsgi_app = SupersetProfiler(app.wsgi_app) # type: ignore | |||
Codecov Report
@@ Coverage Diff @@
## master #16136 +/- ##
==========================================
- Coverage 76.83% 76.58% -0.26%
==========================================
Files 995 996 +1
Lines 52884 52913 +29
Branches 6721 6721
==========================================
- Hits 40636 40526 -110
- Misses 12023 12162 +139
Partials 225 225
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
betodealmeida
force-pushed
the
feat_profiling
branch
from
5c80d60
to
034464d
Compare
john-bodley
reviewed
Aug 9, 2021
john-bodley
reviewed
Aug 9, 2021
| from werkzeug.wrappers import Request, Response | ||
|
|
||
|
|
||
| class SupersetProfiler: |
There was a problem hiding this comment.
@betodealmeida would this be better defined an extension?
There was a problem hiding this comment.
We still need the WSGI middleware, but I'll add an extension to register and set it up.
dpgaspar
approved these changes
Aug 9, 2021
There was a problem hiding this comment.
This is great, LGTM after addressing @john-bodley comment(s)
betodealmeida
force-pushed
the
feat_profiling
branch
from
2ed623a
to
aaece1d
Compare
villebro
pushed a commit
to preset-io/superset
that referenced
this pull request
Oct 12, 2021
* feat: add profiling to Superset pages * Address comments
opus-42
pushed a commit
to opus-42/incubator-superset
that referenced
this pull request
Nov 14, 2021
* feat: add profiling to Superset pages * Address comments
QAlexBall
pushed a commit
to QAlexBall/superset
that referenced
this pull request
Dec 28, 2021
* feat: add profiling to Superset pages * Address comments
mistercrunch
added
🏷️ bot
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
Add Python instrumentation to pages, showing method calls used to build the page, and how long each one took.
Requires a configuration flag
PROFILING=True, and appending_instrument=1to the URL.BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
http://localhost:9000/superset/welcome/?_instrument=1
TESTING INSTRUCTIONS
ADDITIONAL INFORMATION