fix: nvd3 bar chart sortby metric #15318
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zhaoyongjie
commented
Jun 23, 2021
| @@ -999,7 +1000,8 @@ def test_explore_json_dist_bar_order(self): | |||
| SELECT count(name) AS count_name, count(ds) AS count_ds | |||
| FROM birth_names | |||
| WHERE ds >= '1921-01-22 00:00:00.000000' AND ds < '2021-01-22 00:00:00.000000' | |||
| GROUP BY name ORDER BY count_name DESC, count_ds DESC | |||
There was a problem hiding this comment.
For the distributed bar only a single metric can be sorted.
Codecov Report
@@ Coverage Diff @@
## master #15318 +/- ##
==========================================
+ Coverage 77.14% 77.22% +0.08%
==========================================
Files 973 973
Lines 50473 50481 +8
Branches 6183 6183
==========================================
+ Hits 38938 38985 +47
+ Misses 11329 11290 -39
Partials 206 206
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
villebro
approved these changes
Jun 30, 2021
9 tasks
cccs-RyanS
pushed a commit
to CybercentreCanada/superset
that referenced
this pull request
Dec 17, 2021
QAlexBall
pushed a commit
to QAlexBall/superset
that referenced
this pull request
Dec 29, 2021
cccs-rc
pushed a commit
to CybercentreCanada/superset
that referenced
this pull request
Mar 6, 2024
mistercrunch
added
🏷️ bot
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
currently, nvd3 bar chart(non-timeseries) can not be sorted by metric. this PR fixed it.
closes: #15260
BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
before
issue link: #15260
after
Jun-23-2021.02-34-07.mp4
TESTING INSTRUCTIONS
tested in local
ADDITIONAL INFORMATION