Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(db_engine_specs): Add quirks to support Ascend.io/HiveServer2 with Impala driver. #14682

Merged
merged 1 commit into from
Jun 18, 2021

Conversation

danielewood
Copy link
Contributor

@danielewood danielewood commented May 18, 2021

SUMMARY

This adds the quirks of Ascend.io's database to be handled using the Impala driver.

Note: I'm unsure if this approach for adding the db_engine_specs is the desired method, so I welcome feedback for needed changes.

Edit: I have modified the PR as my proposed changes for modifying get_table_names has been accepted in the latest Impala driver upstream, so there is no need for that when using impyla>=0.17a8 (should be released shortly).

Changes:

  1. Adds ascend:// db_engine_spec that uses the Impala/Impyla driver
  2. Use the default postgres time grain expressions to make charts work
  3. Updated docs.

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

TEST PLAN

ADDITIONAL INFORMATION

  • Has associated issue:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

@codecov
Copy link

codecov bot commented May 18, 2021

Codecov Report

Merging #14682 (1a3a4c5) into master (568061e) will increase coverage by 0.09%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #14682      +/-   ##
==========================================
+ Coverage   77.46%   77.56%   +0.09%     
==========================================
  Files         959      960       +1     
  Lines       48465    48527      +62     
  Branches     5678     5678              
==========================================
+ Hits        37545    37638      +93     
+ Misses      10720    10689      -31     
  Partials      200      200              
Flag Coverage Δ
hive 81.12% <100.00%> (+0.15%) ⬆️
mysql 81.39% <100.00%> (+0.15%) ⬆️
postgres 81.41% <100.00%> (+0.15%) ⬆️
presto 81.12% <100.00%> (+0.16%) ⬆️
python 81.95% <100.00%> (+0.16%) ⬆️
sqlite 81.04% <100.00%> (+0.15%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
superset/db_engine_specs/ascend.py 100.00% <100.00%> (ø)
superset/connectors/base/models.py 88.03% <0.00%> (-2.66%) ⬇️
superset/reports/logs/api.py 94.11% <0.00%> (-1.34%) ⬇️
superset/exceptions.py 98.70% <0.00%> (-1.30%) ⬇️
superset/connectors/sqla/models.py 90.14% <0.00%> (-0.13%) ⬇️
superset/views/core.py 75.48% <0.00%> (-0.04%) ⬇️
superset/utils/urls.py 100.00% <0.00%> (ø)
superset/databases/api.py 92.41% <0.00%> (ø)
superset/views/dynamic_plugins.py 100.00% <0.00%> (ø)
superset/databases/commands/create.py 92.15% <0.00%> (ø)
... and 13 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 568061e...1a3a4c5. Read the comment docs.

@junlincc junlincc requested a review from betodealmeida May 18, 2021 06:07
@junlincc junlincc added the data:connect:impala Related to Impala label May 18, 2021
@danielewood
Copy link
Contributor Author

A review would be appreciated.

Copy link
Member

@betodealmeida betodealmeida left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, sorry for missing this!

@betodealmeida betodealmeida merged commit a102715 into apache:master Jun 18, 2021
cccs-RyanS pushed a commit to CybercentreCanada/superset that referenced this pull request Dec 17, 2021
QAlexBall pushed a commit to QAlexBall/superset that referenced this pull request Dec 29, 2021
cccs-rc pushed a commit to CybercentreCanada/superset that referenced this pull request Mar 6, 2024
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 1.3.0 labels Mar 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels data:connect:impala Related to Impala size/M 🚢 1.3.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants