-
Notifications
You must be signed in to change notification settings - Fork 14.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(db_engine_specs): Add quirks to support Ascend.io/HiveServer2 with Impala driver. #14682
Conversation
Codecov Report
@@ Coverage Diff @@
## master #14682 +/- ##
==========================================
+ Coverage 77.46% 77.56% +0.09%
==========================================
Files 959 960 +1
Lines 48465 48527 +62
Branches 5678 5678
==========================================
+ Hits 37545 37638 +93
+ Misses 10720 10689 -31
Partials 200 200
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
66634f4
to
1a3a4c5
Compare
A review would be appreciated. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great, sorry for missing this!
SUMMARY
This adds the quirks of Ascend.io's database to be handled using the Impala driver.
Note: I'm unsure if this approach for adding the db_engine_specs is the desired method, so I welcome feedback for needed changes.
Edit: I have modified the PR as my proposed changes for modifying get_table_names has been accepted in the latest Impala driver upstream, so there is no need for that when using impyla>=0.17a8 (should be released shortly).
Changes:
BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
TEST PLAN
ADDITIONAL INFORMATION