-
Notifications
You must be signed in to change notification settings - Fork 14.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weβll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: Removes react-bootstrap and react-bootstrap-slider #14641
chore: Removes react-bootstrap and react-bootstrap-slider #14641
Conversation
Codecov Report
@@ Coverage Diff @@
## master #14641 +/- ##
=======================================
Coverage 77.46% 77.46%
=======================================
Files 958 958
Lines 48478 48478
Branches 5681 5681
=======================================
Hits 37553 37553
Misses 10725 10725
Partials 200 200
Flags with carried forward coverage won't be shown. Click here to find out more. Continue to review full report at Codecov.
|
Thank you so much for completing π― the project(all the dangerous work is done), your work is much appreciated. @michael-s-molina π |
cef3b1e
to
8f9c8ea
Compare
8f9c8ea
to
f1fc238
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
SUMMARY
Removes
react-bootstrap
andreact-bootstrap-slider
.π₯³ πΊπΌ β π― π πͺπΌ π₯ π₯
@junlincc @rusackas
Depends on: apache-superset/superset-ui#1108
TEST PLAN
1 - Execute all tests
2 - All tests should pass
ADDITIONAL INFORMATION