Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: dashboard side actions #14587

Merged
merged 2 commits into from
May 12, 2021
Merged

fix: dashboard side actions #14587

merged 2 commits into from
May 12, 2021

Conversation

pkdotson
Copy link
Member

SUMMARY

This pr fixes the issues where the dashboard side actions aren't displayed when in edit mode.

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

Screen.Recording.2021-05-11.at.9.53.54.PM.mov

TEST PLAN

ADDITIONAL INFORMATION

  • [x ] Has associated issue: 14554
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

@pkdotson pkdotson mentioned this pull request May 12, 2021
Closed
@codecov
Copy link

codecov bot commented May 12, 2021

Codecov Report

Merging #14587 (dc54154) into master (7d28225) will increase coverage by 0.00%.
The diff coverage is 100.00%.

❗ Current head dc54154 differs from pull request most recent head ecf4113. Consider uploading reports for the commit ecf4113 to get more accurate results
Impacted file tree graph

@@           Coverage Diff           @@
##           master   #14587   +/-   ##
=======================================
  Coverage   77.40%   77.40%           
=======================================
  Files         958      958           
  Lines       48327    48329    +2     
  Branches     5677     5679    +2     
=======================================
+ Hits        37406    37410    +4     
+ Misses      10721    10719    -2     
  Partials      200      200
Flag Coverage Δ
javascript 72.47% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...components/DashboardBuilder/DashboardContainer.tsx 100.00% <ø> (ø)
...-frontend/src/datasource/ChangeDatasourceModal.tsx 85.36% <ø> (ø)
superset-frontend/src/components/Alert/index.tsx 100.00% <100.00%> (ø)
superset/db_engine_specs/presto.py 90.31% <0.00%> (+0.42%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7d28225...ecf4113. Read the comment docs.

@junlincc junlincc added rush! Requires immediate attention #bug:blocking! Blocking issues with high priority labels May 12, 2021
@junlincc
Copy link
Member

/testenv up

@junlincc junlincc added the bash! label May 12, 2021
@rusackas
Copy link
Member

/testenv up

@rusackas
Copy link
Member

Code looks simple enough... easy review!
Waiting on the ephemeral build to verify.

Two questions for @pkdotson:

  1. Was it tested with and without the Native Filters feature flag enabled?
  2. Can you think of any sort of regression test we can add here? RTL's toBeVisible doesn't seem sufficient here.

graceguo-supercat
graceguo-supercat approved these changes May 12, 2021
View reviewed changes
Copy link

@graceguo-supercat graceguo-supercat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@junlincc
Copy link
Member

  1. Was it tested with and without the Native Filters feature flag enabled?
    Tested Yes

@rusackas rusackas merged commit bfbf767 into apache:master May 12, 2021
@rusackas rusackas deleted the fix-dashboard-container branch May 12, 2021 18:47
@github-actions
Copy link
Contributor

Ephemeral environment shutdown and build artifacts deleted.

@github-actions
Copy link
Contributor

@junlincc Ephemeral environment creation failed. Please check the Actions logs for details.

@github-actions
Copy link
Contributor

@rusackas Container image not yet published for this PR. Please try again when build is complete.

@github-actions
Copy link
Contributor

@rusackas Ephemeral environment creation failed. Please check the Actions logs for details.

amitmiran137 pushed a commit that referenced this pull request May 13, 2021
@pkdotson
fix: dashboard side actions (#14587)
69e24bb 
* fix dashboard side actions

* lint being lint

(cherry picked from commit bfbf767)
@yousoph
Copy link
Member

yousoph commented May 13, 2021

🏷️ 2021.19

serenajiang pushed a commit to airbnb/superset-fork that referenced this pull request May 17, 2021
@pkdotson @serenajiang
fix: dashboard side actions (apache#14587)
d20ab52 
* fix dashboard side actions

* lint being lint
henryyeh pushed a commit to preset-io/superset that referenced this pull request May 18, 2021
@pkdotson @henryyeh
fix: dashboard side actions (apache#14587)
e5c6472 
* fix dashboard side actions

* lint being lint

(cherry picked from commit bfbf767)
@junlincc junlincc removed #bug:blocking! Blocking issues with high priority rush! Requires immediate attention labels May 27, 2021
cccs-RyanS pushed a commit to CybercentreCanada/superset that referenced this pull request Sep 8, 2021
@pkdotson @cccs-RyanS
fix: dashboard side actions (apache#14587)
e03598c 
* fix dashboard side actions

* lint being lint

(cherry picked from commit bfbf767)
cccs-RyanS pushed a commit to CybercentreCanada/superset that referenced this pull request Dec 17, 2021
@pkdotson
fix: dashboard side actions (apache#14587)
71da2c2 
* fix dashboard side actions

* lint being lint
QAlexBall pushed a commit to QAlexBall/superset that referenced this pull request Dec 29, 2021
@pkdotson
fix: dashboard side actions (apache#14587)
b8a0541 
* fix dashboard side actions

* lint being lint
cccs-rc pushed a commit to CybercentreCanada/superset that referenced this pull request Mar 6, 2024
@pkdotson
fix: dashboard side actions (apache#14587)
fa04955 
* fix dashboard side actions

* lint being lint
@mistercrunch mistercrunch added 🍒 1.2.0 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 1.3.0 labels Mar 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@graceguo-supercat graceguo-supercat graceguo-supercat approved these changes

Assignees
No one assigned
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels preset:2021.19 preset-io size/XS v1.2 🍒 1.2.0 🚢 1.3.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@pkdotson @junlincc @rusackas @yousoph @graceguo-supercat @mistercrunch @amitmiran137