Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(UPDATING): Adding downtime for #14234 #14513

Merged
merged 1 commit into from
May 7, 2021

Conversation

john-bodley
Copy link
Member

SUMMARY

Adding a missing entry to UPDATING.md associated with #14234 which includes a database migration involving a DDL operation.

@robdiciuccio I wonder if we should update SIP-59 to make sure that all DDL migrations are added to the UPDATING.md since they will likely require downtime for MySQL backed installations.

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

TEST PLAN

ADDITIONAL INFORMATION

  • Has associated issue:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

@codecov
Copy link

codecov bot commented May 7, 2021

Codecov Report

Merging #14513 (9816a67) into master (52dbe31) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master   #14513   +/-   ##
=======================================
  Coverage   77.15%   77.15%           
=======================================
  Files         958      958           
  Lines       48241    48241           
  Branches     5636     5636           
=======================================
  Hits        37219    37219           
  Misses      10821    10821           
  Partials      201      201           
Flag Coverage Δ
hive 80.80% <ø> (ø)
javascript 72.01% <ø> (ø)
mysql 81.06% <ø> (ø)
postgres 81.09% <ø> (ø)
presto 80.79% <ø> (ø)
python 81.63% <ø> (ø)
sqlite 80.70% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.


Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 52dbe31...9816a67. Read the comment docs.

@john-bodley john-bodley merged commit 6871ad1 into master May 7, 2021
cccs-RyanS pushed a commit to CybercentreCanada/superset that referenced this pull request Dec 17, 2021
QAlexBall pushed a commit to QAlexBall/superset that referenced this pull request Dec 29, 2021
@rusackas rusackas deleted the john-bodley--add-downtime-to-updating branch January 30, 2023 19:21
cccs-rc pushed a commit to CybercentreCanada/superset that referenced this pull request Mar 6, 2024
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 1.3.0 labels Mar 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels size/XS 🚢 1.3.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants