chore: Moves the images folder to the assets folder #14429

michael-s-molina · 2021-04-30T13:24:58Z

SUMMARY

Moves the images folder to the assets folder.

This work is part of SIP-61

@rusackas @pkdotson please include anyone that needs to be aware of this. I tested the Storybook, development, and production versions and it seems ok. Please let me know if I forgot any dependency.

PS: Don't panic about the 317 files changed 😆, most are just file renames.

TEST PLAN

Create an ephemeral environment and test the application
Test the Storybook
Test the build process

ADDITIONAL INFORMATION

Has associated issue:
Changes UI
Includes DB Migration (follow approval process in SIP-59)
- Migration is atomic, supports rollback & is backwards-compatible
- Confirm DB migration upgrade and downgrade tested
- Runtime estimates and downtime expectations provided
Introduces new feature or API
Removes existing feature or API

codecov · 2021-04-30T13:48:22Z

Codecov Report

Merging #14429 (66cf0c9) into master (9b17e86) will increase coverage by 0.31%.
The diff coverage is n/a.

❗ Current head 66cf0c9 differs from pull request most recent head a34b8c5. Consider uploading reports for the commit a34b8c5 to get more accurate results

@@            Coverage Diff             @@
##           master   #14429      +/-   ##
==========================================
+ Coverage   76.67%   76.98%   +0.31%     
==========================================
  Files        1005     1007       +2     
  Lines       54138    54174      +36     
  Branches     7442     7463      +21     
==========================================
+ Hits        41510    41708     +198     
+ Misses      12384    12226     -158     
+ Partials      244      240       -4

Flag	Coverage Δ
javascript	`71.30% <ø> (+0.21%)`	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files	Coverage Δ
...rontend/src/components/ListView/Filters/Search.tsx	`82.35% <0.00%> (-12.89%)`	⬇️
superset-frontend/src/views/CRUD/hooks.ts	`46.98% <0.00%> (-0.68%)`	⬇️
superset/reports/commands/execute.py	`90.23% <0.00%> (-0.61%)`	⬇️
...rontend/src/views/CRUD/dashboard/DashboardList.tsx	`71.83% <0.00%> (-0.40%)`	⬇️
...erset-frontend/src/datasource/DatasourceEditor.jsx	`74.81% <0.00%> (-0.28%)`	⬇️
...rset-frontend/src/components/ListView/ListView.tsx	`96.19% <0.00%> (-0.11%)`	⬇️
superset/views/core.py	`76.29% <0.00%> (-0.06%)`	⬇️
superset/sql_parse.py	`99.38% <0.00%> (-0.02%)`	⬇️
superset-frontend/src/components/Icons/Icon.tsx	`100.00% <0.00%> (ø)`
superset-frontend/src/reports/actions/reports.js	`41.17% <0.00%> (ø)`
... and 65 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 486e0d4...a34b8c5. Read the comment docs.

rusackas · 2021-05-06T05:02:53Z

/testenv up

github-actions · 2021-05-06T05:10:08Z

@rusackas Ephemeral environment spinning up at http://52.12.116.219:8080. Credentials are admin/admin. Please allow several minutes for bootstrapping and startup.

geido

Hey @michael-s-molina we need to make sure that the path is changed for the dynamic import of the Icons component as well. I don't see that path change included here

michael-s-molina · 2021-05-06T17:04:32Z

Hey @michael-s-molina we need to make sure that the path is changed for the dynamic import of the Icons component as well. I don't see that path change included here

@geido This one?

geido · 2021-05-06T19:40:44Z

Hey @michael-s-molina we need to make sure that the path is changed for the dynamic import of the Icons component as well. I don't see that path change included here

@geido This one?

@michael-s-molina Is this in this PR? I have looked 3 times. I can't find it.

michael-s-molina · 2021-05-06T19:43:34Z

Is this in this PR? I have looked 3 times. I can't find it.

@geido https://github.com/apache/superset/pull/14429/files#diff-4ee0a8eefdf7b42a39b21a7183b6559a4909da71533312d9eba61c569234862f

geido · 2021-05-06T19:46:57Z

Is this in this PR? I have looked 3 times. I can't find it.

@geido https://github.com/apache/superset/pull/14429/files#diff-4ee0a8eefdf7b42a39b21a7183b6559a4909da71533312d9eba61c569234862f

That does not bring me to that change. I am from the Github app, maybe it is messed up due to the big amount of changes. But if you confirm it is there, then we are good @michael-s-molina

rusackas · 2021-05-21T21:53:14Z

superset-frontend/src/assets/staticPages/404.html

@@ -94,14 +94,14 @@
      <section>
        <h1>Page not found</h1>
        <p>
-          Sorry, we cannot find t he page you are looking for. You may have
+          Sorry, we cannot find the page you are looking for. You may have


Nice catch :)

rusackas · 2021-05-21T21:54:29Z

/testenv up

github-actions · 2021-05-21T21:59:21Z

@rusackas Ephemeral environment spinning up at http://52.13.96.30:8080. Credentials are admin/admin. Please allow several minutes for bootstrapping and startup.

etr2460

it looks like a lot of the images in the directory are only used for documentation or on the docs website. can you verify before merging that they don't get deployed to the docker image, since they aren't needed to actually run the server?

geido

LGTM! Thanks!

villebro · 2021-09-22T13:22:13Z

it looks like a lot of the images in the directory are only used for documentation or on the docs website. can you verify before merging that they don't get deployed to the docker image, since they aren't needed to actually run the server?

I can confirm that I was not able to find the doc/website images in the docker image. So should be good to go 👍

villebro

LGTM!

github-actions · 2021-09-22T13:29:17Z

Ephemeral environment shutdown and build artifacts deleted.

* chore: Moves the images folder to the assets folder * Rebases

superset-github-bot bot added the Turing label Apr 30, 2021

junlincc added the sip:61:folder-org Related to the organization of the folders as of SIP 61 label May 5, 2021

junlincc requested review from rusackas and ktmud May 5, 2021 00:31

geido requested changes May 6, 2021

View reviewed changes

rusackas reviewed May 21, 2021

View reviewed changes

michael-s-molina force-pushed the move-images-to-assets-folder branch from 5eacfb9 to 16f363f Compare September 17, 2021 13:28

pull-request-size bot added the size/M label Sep 17, 2021

michael-s-molina requested review from geido, rusackas, amitmiran137, etr2460 and villebro September 17, 2021 13:29

etr2460 reviewed Sep 17, 2021

View reviewed changes

geido approved these changes Sep 17, 2021

View reviewed changes

michael-s-molina added 2 commits September 22, 2021 08:28

chore: Moves the images folder to the assets folder

7fc0c46

Rebases

a34b8c5

michael-s-molina force-pushed the move-images-to-assets-folder branch from 16f363f to a34b8c5 Compare September 22, 2021 11:33

villebro approved these changes Sep 22, 2021

View reviewed changes

michael-s-molina merged commit 99d15b2 into apache:master Sep 22, 2021

opus-42 pushed a commit to opus-42/incubator-superset that referenced this pull request Nov 14, 2021

chore: Moves the images folder to the assets folder (apache#14429)

5a99d29

* chore: Moves the images folder to the assets folder * Rebases

QAlexBall pushed a commit to QAlexBall/superset that referenced this pull request Dec 28, 2021

chore: Moves the images folder to the assets folder (apache#14429)

07ecc27

* chore: Moves the images folder to the assets folder * Rebases

mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 1.4.0 labels Mar 12, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

chore: Moves the images folder to the assets folder #14429

chore: Moves the images folder to the assets folder #14429

michael-s-molina commented Apr 30, 2021 •

edited

Loading

codecov bot commented Apr 30, 2021 •

edited

Loading

rusackas commented May 6, 2021

github-actions bot commented May 6, 2021

geido left a comment

michael-s-molina commented May 6, 2021

geido commented May 6, 2021 •

edited

Loading

michael-s-molina commented May 6, 2021

geido commented May 6, 2021

rusackas May 21, 2021

rusackas commented May 21, 2021

github-actions bot commented May 21, 2021

etr2460 left a comment

geido left a comment

villebro commented Sep 22, 2021

villebro left a comment

github-actions bot commented Sep 22, 2021

chore: Moves the images folder to the assets folder #14429

chore: Moves the images folder to the assets folder #14429

Conversation

michael-s-molina commented Apr 30, 2021 • edited Loading

SUMMARY

TEST PLAN

ADDITIONAL INFORMATION

codecov bot commented Apr 30, 2021 • edited Loading

Codecov Report

rusackas commented May 6, 2021

github-actions bot commented May 6, 2021

geido left a comment

Choose a reason for hiding this comment

michael-s-molina commented May 6, 2021

geido commented May 6, 2021 • edited Loading

michael-s-molina commented May 6, 2021

geido commented May 6, 2021

rusackas May 21, 2021

Choose a reason for hiding this comment

rusackas commented May 21, 2021

github-actions bot commented May 21, 2021

etr2460 left a comment

Choose a reason for hiding this comment

geido left a comment

Choose a reason for hiding this comment

villebro commented Sep 22, 2021

villebro left a comment

Choose a reason for hiding this comment

github-actions bot commented Sep 22, 2021

michael-s-molina commented Apr 30, 2021 •

edited

Loading

codecov bot commented Apr 30, 2021 •

edited

Loading

geido commented May 6, 2021 •

edited

Loading