feat(native-filters): add option to create value in select filter #14314
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
villebro
force-pushed
the
villebro/native-select-creatable
branch
from
8f43595 to
6f268c6
Compare
Codecov Report
@@ Coverage Diff @@
## master #14314 +/- ##
==========================================
- Coverage 76.93% 76.93% -0.01%
==========================================
Files 954 954
Lines 48075 48082 +7
Branches 5974 5976 +2
==========================================
+ Hits 36987 36991 +4
- Misses 10891 10894 +3
Partials 197 197
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
villebro
force-pushed
the
villebro/native-select-creatable
branch
from
6f268c6 to
8bb466c
Compare
kgabryje
reviewed
Apr 23, 2021
| @@ -150,6 +155,9 @@ export default function PluginFilterSelect(props: PluginFilterSelectProps) { | |||
| showSearch={showSearch} | |||
| mode={multiSelect ? 'multiple' : undefined} | |||
| placeholder={placeholderText} | |||
| onSearch={val => setCurrentSuggestionSearch(val)} | |||
There was a problem hiding this comment.
Suggested change
| onSearch={val => setCurrentSuggestionSearch(val)} | |
| onSearch={setCurrentSuggestionSearch} |
| @@ -163,6 +171,14 @@ export default function PluginFilterSelect(props: PluginFilterSelectProps) { | |||
| </Option> | |||
| ); | |||
| })} | |||
| {currentSuggestionSearch && | |||
| !(values || []).some( | |||
There was a problem hiding this comment.
WDYT about using ensureIsArray(values) instead of values || []? I'm not sure if it'd be easier to read, but maybe a bit safer in case values is not an array
kgabryje
approved these changes
Apr 23, 2021
This was referenced Apr 25, 2021
junlincc
added
the
dashboard:native-filters
QAlexBall
pushed a commit
to QAlexBall/superset
that referenced
this pull request
Dec 29, 2021
…ache#14314) * feat(native-filters): add option to create value in select filter * address comments
mistercrunch
added
🏷️ bot
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
This is a port of #13029 to native filters to make it possible to add select filters that are not contained in the input data.
SCREENSHOTS
Single select filter:
Multiselect filter:
TEST PLAN
ADDITIONAL INFORMATION