-
Notifications
You must be signed in to change notification settings - Fork 14.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Center each import icon and add a tooltip II #14192
fix: Center each import icon and add a tooltip II #14192
Conversation
superset-frontend/spec/javascripts/views/CRUD/data/database/DatabaseList_spec.jsx
Show resolved
Hide resolved
Codecov Report
@@ Coverage Diff @@
## master #14192 +/- ##
==========================================
- Coverage 79.24% 76.15% -3.10%
==========================================
Files 945 945
Lines 47950 47928 -22
Branches 6069 5950 -119
==========================================
- Hits 37998 36498 -1500
- Misses 9817 11224 +1407
- Partials 135 206 +71
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
ac1d4b7
to
001d70c
Compare
/testenv up |
@hughhhh Ephemeral environment spinning up at http://35.161.27.87:8080. Credentials are |
/testenv up FEATURE_VERSIONED_EXPORT=true |
@hughhhh Ephemeral environment spinning up at http://54.200.53.244:8080. Credentials are |
@lyndsiWilliams thanks for this work here! Here are the capitalization guidelines for copy: Objects are not considered proper nouns so the tooltip should read: "Import saved query" not "Import Saved Query". Additionally, let's change the copy to read "Import queries" instead. Copy to use:
cc @yousoph |
/testenv up FEATURE_VERSIONED_EXPORT=true |
@hughhhh Ephemeral environment spinning up at http://54.149.249.58:8080. Credentials are |
Ephemeral environment shutdown and build artifacts deleted. |
SUMMARY
I have added a tooltip with text "Import [object]" (example: "Import Database", "Import Dataset", etc.) on all occurrences of the import icon: Database, Dataset, Chart, Dashboard, Saved Query. I have also centered each tooltip icon.
BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
BEFORE:
AFTER:
TEST PLAN
ADDITIONAL INFORMATION