Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Center each import icon and add a tooltip II #14192

Merged
merged 6 commits into from
Apr 20, 2021

Conversation

lyndsiWilliams
Copy link
Member

SUMMARY

I have added a tooltip with text "Import [object]" (example: "Import Database", "Import Dataset", etc.) on all occurrences of the import icon: Database, Dataset, Chart, Dashboard, Saved Query. I have also centered each tooltip icon.

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

BEFORE:

import-icon-before

AFTER:

import-icon-after

TEST PLAN

  • Navigate to all pages with an import icon (Database, Dataset, Chart, Dashboard, Saved Query)
  • Observe that the icon is centered with it's neighboring button(s)
  • Hover mouse pointer over the import icon
  • Observe the appropriate relative "Import [object]" tooltip

ADDITIONAL INFORMATION

  • Has associated issue: [Design]Import chart/dashboard UI icon is misleading #13920
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

@lyndsiWilliams lyndsiWilliams marked this pull request as ready for review April 16, 2021 17:40
@codecov
Copy link

codecov bot commented Apr 16, 2021

Codecov Report

Merging #14192 (1fecae3) into master (df04c3a) will decrease coverage by 3.09%.
The diff coverage is 93.10%.

❗ Current head 1fecae3 differs from pull request most recent head 7cb39ab. Consider uploading reports for the commit 7cb39ab to get more accurate results
Impacted file tree graph

@@            Coverage Diff             @@
##           master   #14192      +/-   ##
==========================================
- Coverage   79.24%   76.15%   -3.10%     
==========================================
  Files         945      945              
  Lines       47950    47928      -22     
  Branches     6069     5950     -119     
==========================================
- Hits        37998    36498    -1500     
- Misses       9817    11224    +1407     
- Partials      135      206      +71     
Flag Coverage Δ
cypress ?
javascript 70.27% <87.09%> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...erset-frontend/src/SqlLab/components/SqlEditor.jsx 54.62% <ø> (-1.39%) ⬇️
...rontend/src/SqlLab/components/SqlEditorLeftBar.jsx 53.22% <ø> (-3.23%) ⬇️
...et-frontend/src/SqlLab/components/TableElement.jsx 89.02% <ø> (ø)
...uperset-frontend/src/components/Collapse/index.tsx 100.00% <ø> (ø)
...rset-frontend/src/components/ErrorMessage/types.ts 100.00% <ø> (ø)
superset-frontend/src/components/Menu/SubMenu.tsx 100.00% <ø> (ø)
superset-frontend/src/components/Modal/Modal.tsx 100.00% <ø> (ø)
superset-frontend/src/components/Modal/index.ts 100.00% <ø> (ø)
...set-frontend/src/components/ModalTrigger/index.jsx 95.65% <ø> (-4.35%) ⬇️
superset-frontend/src/dashboard/actions/hydrate.js 3.36% <0.00%> (-71.00%) ⬇️
... and 234 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update df04c3a...7cb39ab. Read the comment docs.

@lyndsiWilliams lyndsiWilliams force-pushed the lyndsi/fix-import-icon-tooltip branch from ac1d4b7 to 001d70c Compare April 16, 2021 18:10
@hughhhh
Copy link
Member

hughhhh commented Apr 16, 2021

/testenv up

@github-actions
Copy link
Contributor

@hughhhh Ephemeral environment spinning up at http://35.161.27.87:8080. Credentials are admin/admin. Please allow several minutes for bootstrapping and startup.

@hughhhh
Copy link
Member

hughhhh commented Apr 16, 2021

/testenv up FEATURE_VERSIONED_EXPORT=true

@github-actions
Copy link
Contributor

@hughhhh Ephemeral environment spinning up at http://54.200.53.244:8080. Credentials are admin/admin. Please allow several minutes for bootstrapping and startup.

@Steejay
Copy link

Steejay commented Apr 19, 2021

@lyndsiWilliams thanks for this work here! Here are the capitalization guidelines for copy:
https://github.com/apache/superset/wiki/Capitalization-Guidelines

Objects are not considered proper nouns so the tooltip should read: "Import saved query" not "Import Saved Query". Additionally, let's change the copy to read "Import queries" instead.

Copy to use:

  • Import queries
  • Import dashboards
  • Import datasets
  • Import charts

cc @yousoph

@hughhhh
Copy link
Member

hughhhh commented Apr 19, 2021

/testenv up FEATURE_VERSIONED_EXPORT=true

@github-actions
Copy link
Contributor

@hughhhh Ephemeral environment spinning up at http://54.149.249.58:8080. Credentials are admin/admin. Please allow several minutes for bootstrapping and startup.

@hughhhh hughhhh merged commit a846015 into apache:master Apr 20, 2021
@github-actions
Copy link
Contributor

Ephemeral environment shutdown and build artifacts deleted.

@lyndsiWilliams lyndsiWilliams deleted the lyndsi/fix-import-icon-tooltip branch October 15, 2021 01:32
QAlexBall pushed a commit to QAlexBall/superset that referenced this pull request Dec 29, 2021
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 1.2.0 labels Mar 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels size/L 🚢 1.2.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants