Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: error messages when connecting to mssql #14171

Merged
merged 2 commits into from
Apr 16, 2021

Conversation

AAfghahi
Copy link
Member

SUMMARY

Added custom error messages for an incorrect database name, cleaned up some language in other tests.

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

Screen Shot 2021-04-15 at 12 14 47 PM

TEST PLAN

added unit tests

ADDITIONAL INFORMATION

  • Has associated issue:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

@codecov
Copy link

codecov bot commented Apr 15, 2021

Codecov Report

Merging #14171 (771b81d) into master (fe21de3) will decrease coverage by 0.00%.
The diff coverage is n/a.

❗ Current head 771b81d differs from pull request most recent head 781dac3. Consider uploading reports for the commit 781dac3 to get more accurate results
Impacted file tree graph

@@            Coverage Diff             @@
##           master   #14171      +/-   ##
==========================================
- Coverage   79.87%   79.87%   -0.01%     
==========================================
  Files         944      944              
  Lines       47916    47916              
  Branches     6067     6067              
==========================================
- Hits        38272    38271       -1     
- Misses       9520     9521       +1     
  Partials      124      124              
Flag Coverage Δ
cypress 56.32% <ø> (-0.01%) ⬇️
hive 80.37% <ø> (ø)
mysql 80.64% <ø> (ø)
postgres 80.67% <ø> (ø)
presto 80.39% <ø> (ø)
python 81.23% <ø> (ø)
sqlite 80.27% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
superset/databases/commands/test_connection.py 98.11% <ø> (ø)
superset/db_engine_specs/mssql.py 95.45% <ø> (ø)
superset/errors.py 100.00% <ø> (ø)
...set-frontend/src/dashboard/util/getDropPosition.js 90.90% <0.00%> (-1.52%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fe21de3...781dac3. Read the comment docs.

@pull-request-size pull-request-size bot added size/M and removed size/L labels Apr 15, 2021
@AAfghahi AAfghahi force-pushed the ch6435mssql branch 2 times, most recently from 7d21b76 to b807e3a Compare April 15, 2021 19:52
@betodealmeida betodealmeida self-requested a review April 15, 2021 21:48
{
"code": 1015,
"message": _(
"Issue 1015 - The database is " "spelled incorrectly or does not exist."
Copy link
Member

@betodealmeida betodealmeida Apr 15, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should have the same copy as code 1015 below:

Suggested change
"Issue 1015 - The database is " "spelled incorrectly or does not exist."
"Issue 1015 - Either the database is "
"spelled incorrectly or does not exist."

Copy link
Member

@betodealmeida betodealmeida left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The copy in issue 1015 should be identical everywhere.

@AAfghahi
Copy link
Member Author

sounds good, will update and then ping you.

Copy link
Member

@betodealmeida betodealmeida left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome sauce!

@betodealmeida betodealmeida merged commit df04c3a into apache:master Apr 16, 2021
QAlexBall pushed a commit to QAlexBall/superset that referenced this pull request Dec 29, 2021
* database errors for mssql

* revisions
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 1.2.0 labels Mar 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels size/M 🚢 1.2.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants