-
Notifications
You must be signed in to change notification settings - Fork 14.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: error messages when connecting to mssql #14171
Conversation
Codecov Report
@@ Coverage Diff @@
## master #14171 +/- ##
==========================================
- Coverage 79.87% 79.87% -0.01%
==========================================
Files 944 944
Lines 47916 47916
Branches 6067 6067
==========================================
- Hits 38272 38271 -1
- Misses 9520 9521 +1
Partials 124 124
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
7d21b76
to
b807e3a
Compare
superset/errors.py
Outdated
{ | ||
"code": 1015, | ||
"message": _( | ||
"Issue 1015 - The database is " "spelled incorrectly or does not exist." |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This should have the same copy as code 1015 below:
"Issue 1015 - The database is " "spelled incorrectly or does not exist." | |
"Issue 1015 - Either the database is " | |
"spelled incorrectly or does not exist." |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The copy in issue 1015 should be identical everywhere.
sounds good, will update and then ping you. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome sauce!
* database errors for mssql * revisions
SUMMARY
Added custom error messages for an incorrect database name, cleaned up some language in other tests.
BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
TEST PLAN
added unit tests
ADDITIONAL INFORMATION