fix(dashboard): incorrect perm for users with multiple roles

[ktmud]

SUMMARY

This fixes a bug where dashboard permission check is incorrect when users have multiple roles.

The resulted some users not seeing "View chart in Explore" link in dashboards.

cc @suddjian @pkdotson

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

Before

Some links in chart menu are missing if the user has multiple roles and the last role does not contain permission for [Superset, can_explore].

After

TEST PLAN

To reproduce the bug, add a new role (e.g. sql_lab) to the logged in user.

Added unit tests.

ADDITIONAL INFORMATION

• Has associated issue: chore(spa refactor): refactoring dashboard to use api's instead of bootstrapdata #13306
• Changes UI
• Includes DB Migration (follow approval process in SIP-59)
  • Migration is atomic, supports rollback & is backwards-compatible
  • Confirm DB migration upgrade and downgrade tested
  • Runtime estimates and downtime expectations provided
• Introduces new feature or API
• Removes existing feature or API

[ktmud]

lockfile updated from npm ci.

[suddjian]

LGTM, thank you for fixing. I didn't even realize multiple roles were possible!

[pkdotson]

LGTM! Thanks for tests! I did not know multiple roles were possible as well!

[codecov]

Codecov Report

Merging #14148 (c270fdc) into master (21f973f) will increase coverage by 0.21%.
The diff coverage is 100.00%.

❗ Current head c270fdc differs from pull request most recent head 9871a83. Consider uploading reports for the commit 9871a83 to get more accurate results

@@            Coverage Diff             @@
##           master   #14148      +/-   ##
==========================================
+ Coverage   79.70%   79.92%   +0.21%     
==========================================
  Files         945      943       -2     
  Lines       47975    47757     -218     
  Branches     6082     6015      -67     
==========================================
- Hits        38240    38169      -71     
+ Misses       9614     9469     -145     
+ Partials      121      119       -2     

Flag	Coverage Δ
cypress	56.36% <100.00%> (-0.04%)	⬇️
javascript	70.19% <80.00%> (+0.38%)	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files	Coverage Δ
superset-frontend/src/dashboard/actions/hydrate.js	85.84% <100.00%> (ø)
...rset-frontend/src/dashboard/util/findPermission.ts	100.00% <100.00%> (ø)
superset-frontend/src/filters/utils.ts	95.23% <0.00%> (-4.77%)	⬇️
...dashboard/components/SliceHeaderControls/index.jsx	78.35% <0.00%> (-1.04%)	⬇️
...src/dashboard/components/HeaderActionsDropdown.jsx
...erset-frontend/src/dashboard/components/Header.jsx
.../components/Header/HeaderActionsDropdown/index.jsx	72.36% <0.00%> (+2.63%)	⬆️
...et-frontend/src/components/EditableTitle/index.tsx	86.41% <0.00%> (+11.11%)	⬆️
...frontend/src/dashboard/components/Header/index.jsx	81.02% <0.00%> (+13.86%)	⬆️
...-frontend/src/visualizations/presets/MainPreset.js	100.00% <0.00%> (+33.33%)	⬆️

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 21f973f...9871a83. Read the comment docs.