Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: QueryPane horizontal scroll #14140

Merged
merged 1 commit into from
Apr 14, 2021

Conversation

AAfghahi
Copy link
Member

@AAfghahi AAfghahi commented Apr 14, 2021

SUMMARY

adding new preview tables would push the save button out of view, and also was getting into situations where some tables were inaccesible. We added overflow-x: scroll to the queryPane class, which seems like it solves the issue.

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

Before:
Screen Shot 2021-04-14 at 12 13 30 PM

After:
Screen Shot 2021-04-14 at 12 09 32 PM
Screen Shot 2021-04-14 at 12 09 39 PM

TEST PLAN

This was visually tested.

ADDITIONAL INFORMATION

  • Has associated issue: [SQL lab]Strange horizontal scrolling on SqlLab table #13817
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

@betodealmeida
Copy link
Member

/testenv up

@codecov
Copy link

codecov bot commented Apr 14, 2021

Codecov Report

Merging #14140 (b5b6e33) into master (a548b69) will increase coverage by 0.05%.
The diff coverage is n/a.

❗ Current head b5b6e33 differs from pull request most recent head ddc6ed9. Consider uploading reports for the commit ddc6ed9 to get more accurate results
Impacted file tree graph

@@            Coverage Diff             @@
##           master   #14140      +/-   ##
==========================================
+ Coverage   79.78%   79.83%   +0.05%     
==========================================
  Files         943      943              
  Lines       47748    47749       +1     
  Branches     6026     6016      -10     
==========================================
+ Hits        38094    38122      +28     
+ Misses       9533     9508      -25     
+ Partials      121      119       -2     
Flag Coverage Δ
cypress 56.37% <ø> (+0.01%) ⬆️
javascript 70.17% <ø> (+0.36%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
.../components/Header/HeaderActionsDropdown/index.jsx 72.36% <ø> (ø)
...frontend/src/dashboard/components/Header/index.jsx 81.02% <ø> (ø)
...-frontend/src/visualizations/presets/MainPreset.js 66.66% <0.00%> (-33.34%) ⬇️
...et-frontend/src/components/EditableTitle/index.tsx 86.41% <0.00%> (+11.11%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 474f1e2...ddc6ed9. Read the comment docs.

@github-actions
Copy link
Contributor

@betodealmeida Ephemeral environment spinning up at http://34.220.227.229:8080. Credentials are admin/admin. Please allow several minutes for bootstrapping and startup.

@betodealmeida betodealmeida merged commit f1acb2f into apache:master Apr 14, 2021
@github-actions
Copy link
Contributor

Ephemeral environment shutdown and build artifacts deleted.

QAlexBall pushed a commit to QAlexBall/superset that referenced this pull request Dec 29, 2021
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 1.2.0 labels Mar 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels size/XS 🚢 1.2.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants