chore: Moves Tooltip to the components folder

[michael-s-molina]

SUMMARY

Moves Tooltip to the components folder.

This work is part of SIP-61

@rusackas @junlincc

TEST PLAN

1 - Execute all tests
2 - All tests should pass

ADDITIONAL INFORMATION

• Has associated issue:
• Changes UI
• Includes DB Migration (follow approval process in SIP-59)
  • Migration is atomic, supports rollback & is backwards-compatible
  • Confirm DB migration upgrade and downgrade tested
  • Runtime estimates and downtime expectations provided
• Introduces new feature or API
• Removes existing feature or API

[codecov]

Codecov Report

Merging #14137 (b953fb7) into master (55bf72a) will not change coverage.
The diff coverage is 100.00%.

❗ Current head b953fb7 differs from pull request most recent head 387121f. Consider uploading reports for the commit 387121f to get more accurate results

@@           Coverage Diff           @@
##           master   #14137   +/-   ##
=======================================
  Coverage   77.04%   77.04%           
=======================================
  Files         946      946           
  Lines       47985    47985           
  Branches     5962     5962           
=======================================
  Hits        36970    36970           
  Misses      10814    10814           
  Partials      201      201           

Flag	Coverage Δ
javascript	72.15% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files	Coverage Δ
superset-frontend/src/CRUD/Field.jsx	83.33% <ø> (ø)
...rontend/src/SqlLab/components/TabbedSqlEditors.jsx	71.77% <ø> (ø)
...et-frontend/src/SqlLab/components/TableElement.jsx	89.02% <ø> (ø)
...-frontend/src/components/AlteredSliceTag/index.jsx	96.00% <ø> (ø)
...-frontend/src/components/CopyToClipboard/index.jsx	94.28% <ø> (ø)
superset-frontend/src/components/Tooltip/index.tsx	100.00% <ø> (ø)
...src/dashboard/components/PublishedStatus/index.jsx	100.00% <ø> (ø)
...-frontend/src/explore/components/ControlHeader.jsx	85.18% <ø> (ø)
...rontend/src/explore/components/EmbedCodeButton.jsx	80.76% <ø> (ø)
...tend/src/explore/components/ExploreChartHeader.jsx	63.15% <ø> (ø)
... and 40 more

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 55bf72a...387121f. Read the comment docs.

[rusackas]

LGTM, needs rebase.

This PR also makes me wonder if we couldn't add an info prop to the Tooltip and add the styling/features of InfoTooltip into Tooltip that way so that we don't need to maintain two components.

[michael-s-molina]

LGTM, needs rebase.

This PR also makes me wonder if we couldn't add an info prop to the Tooltip and add the styling/features of InfoTooltip into Tooltip that way so that we don't need to maintain two components.

You're totally right. I noticed that now that things are starting to be organized, it's easier to perceive duplicated components or merge-able ones. For me the best example of this is CertifiedIcon, ChartIcon, FaveStar, IconTooltip, RefreshLabel, WarningIconWithTooltip. They could all be merged into an Icon that can be clicked, selected, and have a tooltip. We'll get there in the second wave of refactoring.

[pkdotson]

/testenv up

[github-actions]

@pkdotson Ephemeral environment spinning up at http://34.220.10.240:8080. Credentials are admin/admin. Please allow several minutes for bootstrapping and startup.

[Deena2112]

Plz don't send

…

On Sat, 17 Apr 2021, 10:34 am Phillip Kelley-Dotson, < ***@***.***> wrote: ***@***.**** approved this pull request. — You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub <#14137 (review)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AQYQXLIDJUZFKOIC2KX7BD3TJEJHXANCNFSM425NLS2A> .

[github-actions]

Ephemeral environment shutdown and build artifacts deleted.