-
Notifications
You must be signed in to change notification settings - Fork 14.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: handle chart/data API errors #14040
Conversation
59d7480
to
1199437
Compare
Nice! Good catch on |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Happy that my PR helped!
Codecov Report
@@ Coverage Diff @@
## master #14040 +/- ##
==========================================
- Coverage 79.40% 78.18% -1.22%
==========================================
Files 938 938
Lines 47541 47533 -8
Branches 5940 5940
==========================================
- Hits 37749 37163 -586
- Misses 9666 10230 +564
- Partials 126 140 +14
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
1199437
to
6d6d874
Compare
SUMMARY
Thanks to @betodealmeida's work in #13960, it was pretty trivial to get the new chart data API returning the SIP-40 style error payloads. This PR also refactors the SupersetErrorException a bit to support passing in a SupersetError, naming help for the other exception type would be much appreciated.
TEST PLAN
New unit test, verify that the same error messages are returned when accessing data in a nvd3 line chart and the new table chart and pie chart.
ADDITIONAL INFORMATION
to: @betodealmeida @john-bodley @ktmud @graceguo-supercat