test: FilterSets-utils #14028
Merged
test: FilterSets-utils #14028
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
junlincc
added
dashboard:native-filters
Codecov Report
@@ Coverage Diff @@
## master #14028 +/- ##
==========================================
- Coverage 79.40% 79.36% -0.04%
==========================================
Files 936 938 +2
Lines 47427 47548 +121
Branches 5938 5947 +9
==========================================
+ Hits 37658 37738 +80
- Misses 9643 9689 +46
+ Partials 126 121 -5
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
.../dashboard/components/nativeFilters/FilterBar/FilterSets/utils/findExistingFilterSet.test.ts
Outdated
Show resolved
Hide resolved
.../dashboard/components/nativeFilters/FilterBar/FilterSets/utils/findExistingFilterSet.test.ts
Outdated
Show resolved
Hide resolved
...c/dashboard/components/nativeFilters/FilterBar/FilterSets/utils/generateFiltersSetId.test.ts
Outdated
Show resolved
Hide resolved
| * specific language governing permissions and limitations | ||
| * under the License. | ||
| */ | ||
| import { generateFiltersSetId } from '.'; |
There was a problem hiding this comment.
Maybe also check for expected ID length?
There was a problem hiding this comment.
I'm not sure if the generated string is the same size. But I believe that this is not so important
…rBar/FilterSets/utils/findExistingFilterSet.test.ts Co-authored-by: Michael S. Molina <[email protected]>
…rBar/FilterSets/utils/findExistingFilterSet.test.ts Co-authored-by: Michael S. Molina <[email protected]>
…rBar/FilterSets/utils/generateFiltersSetId.test.ts Co-authored-by: Michael S. Molina <[email protected]>
rusackas
reviewed
Apr 9, 2021
allanco91
pushed a commit
to allanco91/superset
that referenced
this pull request
May 21, 2021
* Tests for "nativeFilters/FilterBar/FilterSets/utils" * Update superset-frontend/src/dashboard/components/nativeFilters/FilterBar/FilterSets/utils/findExistingFilterSet.test.ts Co-authored-by: Michael S. Molina <[email protected]> * Update superset-frontend/src/dashboard/components/nativeFilters/FilterBar/FilterSets/utils/findExistingFilterSet.test.ts Co-authored-by: Michael S. Molina <[email protected]> * Update superset-frontend/src/dashboard/components/nativeFilters/FilterBar/FilterSets/utils/generateFiltersSetId.test.ts Co-authored-by: Michael S. Molina <[email protected]> * Fix: Lint error Co-authored-by: Michael S. Molina <[email protected]>
QAlexBall
pushed a commit
to QAlexBall/superset
that referenced
this pull request
Dec 29, 2021
* Tests for "nativeFilters/FilterBar/FilterSets/utils" * Update superset-frontend/src/dashboard/components/nativeFilters/FilterBar/FilterSets/utils/findExistingFilterSet.test.ts Co-authored-by: Michael S. Molina <[email protected]> * Update superset-frontend/src/dashboard/components/nativeFilters/FilterBar/FilterSets/utils/findExistingFilterSet.test.ts Co-authored-by: Michael S. Molina <[email protected]> * Update superset-frontend/src/dashboard/components/nativeFilters/FilterBar/FilterSets/utils/generateFiltersSetId.test.ts Co-authored-by: Michael S. Molina <[email protected]> * Fix: Lint error Co-authored-by: Michael S. Molina <[email protected]>
mistercrunch
added
🏷️ bot
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
Tests for functions in
src/dashboard/components/nativeFilters/FilterBar/FilterSets/utils