Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: Adds tests to the CssEditor component #13933

Merged
merged 1 commit into from
Apr 7, 2021
Merged

test: Adds tests to the CssEditor component #13933

merged 1 commit into from
Apr 7, 2021

Conversation

michael-s-molina
Copy link
Member

SUMMARY

Adds tests to the CssEditor component.

TEST PLAN

1 - Execute CssEditor tests
2 - All tests should pass

@rusackas @junlincc

ADDITIONAL INFORMATION

  • Has associated issue:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

@codecov
Copy link

codecov bot commented Apr 2, 2021

Codecov Report

Merging #13933 (c8e6bee) into master (9156f08) will decrease coverage by 1.44%.
The diff coverage is 86.00%.

❗ Current head c8e6bee differs from pull request most recent head c66bacc. Consider uploading reports for the commit c66bacc to get more accurate results
Impacted file tree graph

@@            Coverage Diff             @@
##           master   #13933      +/-   ##
==========================================
- Coverage   77.83%   76.38%   -1.45%     
==========================================
  Files         934      935       +1     
  Lines       47320    47372      +52     
  Branches     5913     5950      +37     
==========================================
- Hits        36831    36185     -646     
- Misses      10346    11008     +662     
- Partials      143      179      +36
Flag Coverage Δ
hive ?
javascript 66.31% <90.47%> (+1.68%) ⬆️
presto ?

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...tend/src/SqlLab/components/ScheduleQueryButton.tsx 28.12% <ø> (ø)
...ntend/src/dashboard/components/CssEditor/index.jsx 95.83% <ø> (ø)
...ontrols/AnnotationLayerControl/AnnotationLayer.jsx 84.28% <ø> (ø)
...mponents/controls/AnnotationLayerControl/index.jsx 42.85% <ø> (ø)
...ponents/controls/DndColumnSelectControl/Option.tsx 100.00% <ø> (ø)
.../src/explore/components/controls/SelectControl.jsx 93.75% <ø> (ø)
.../explore/components/controls/TextControl/index.tsx 88.37% <ø> (ø)
superset/config.py 90.74% <ø> (ø)
...perset-frontend/src/explore/components/Control.tsx 91.66% <50.00%> (-3.79%) ⬇️
superset/connectors/sqla/models.py 89.10% <74.35%> (-1.39%) ⬇️
... and 143 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 42c7e2c...c66bacc. Read the comment docs.

pkdotson
pkdotson reviewed Apr 7, 2021
View reviewed changes
superset-frontend/src/dashboard/components/CssEditor/index.jsx
@@ -33,7 +33,6 @@ const propTypes = {
const defaultProps = {
initialCss: '',
onChange: () => {},
templates: [],
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm curious to why this was removed?

superset-frontend/src/dashboard/components/CssEditor/index.jsx
@@ -33,7 +33,6 @@ const propTypes = {
const defaultProps = {
initialCss: '',
onChange: () => {},
templates: [],
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm curious to why this was removed?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

actually nvm, i see not needed really.

pkdotson
pkdotson approved these changes Apr 7, 2021
View reviewed changes
Copy link
Member

@pkdotson pkdotson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@pkdotson pkdotson merged commit b5c95c5 into apache:master Apr 7, 2021
allanco91 pushed a commit to allanco91/superset that referenced this pull request May 21, 2021
@michael-s-molina
test: Adds tests to the CssEditor component (apache#13933)
a288de1
QAlexBall pushed a commit to QAlexBall/superset that referenced this pull request Dec 29, 2021
@michael-s-molina
test: Adds tests to the CssEditor component (apache#13933)
de147f6
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 1.2.0 labels Mar 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yardz yardz yardz approved these changes

@pkdotson pkdotson pkdotson approved these changes

Assignees
No one assigned
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels size/L test:component 🚢 1.2.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@michael-s-molina @yardz @pkdotson @mistercrunch @junlincc