-
Notifications
You must be signed in to change notification settings - Fork 14.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: trigger collapse with onchange #13927
Conversation
c535093
to
07935ba
Compare
07935ba
to
74811c9
Compare
Codecov Report
@@ Coverage Diff @@
## master #13927 +/- ##
==========================================
+ Coverage 77.83% 78.08% +0.25%
==========================================
Files 934 934
Lines 47320 47350 +30
Branches 5913 5943 +30
==========================================
+ Hits 36831 36975 +144
+ Misses 10346 10231 -115
- Partials 143 144 +1
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
74811c9
to
3deb1cb
Compare
3deb1cb
to
1b0e578
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
/testenv up |
@junlincc Ephemeral environment spinning up at http://34.218.44.50:8080. Credentials are |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTG!
Ephemeral environment shutdown and build artifacts deleted. |
(cherry picked from commit abd4051)
SUMMARY
Fixes a bug where the caret wasn't opening/closing collapse tables in sql lab left toolbar
BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
see ticket for before
after:
Screen.Recording.2021-04-01.mov
TEST PLAN
jest test added. For manual testing, you should be able to expand and collapse the tables by clicking on both the header and the icon. Existing functionality should remain, whereby adding a new table should automatically be expanded when it loads.
ADDITIONAL INFORMATION