Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: trigger collapse with onchange #13927

Merged
merged 1 commit into from
Apr 3, 2021

Conversation

eschutho
Copy link
Member

@eschutho eschutho commented Apr 2, 2021

SUMMARY

Fixes a bug where the caret wasn't opening/closing collapse tables in sql lab left toolbar

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

see ticket for before

after:

Screen.Recording.2021-04-01.mov

TEST PLAN

jest test added. For manual testing, you should be able to expand and collapse the tables by clicking on both the header and the icon. Existing functionality should remain, whereby adding a new table should automatically be expanded when it loads.

ADDITIONAL INFORMATION

  • Has associated issue: [SQL Lab] Expand/Collapse Arrow is not working #13903
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

@eschutho eschutho force-pushed the elizabeth/fix-collapse-bug branch from c535093 to 07935ba Compare April 2, 2021 01:43
@pull-request-size pull-request-size bot added size/L and removed size/M labels Apr 2, 2021
@eschutho eschutho changed the title catch collapse onchange fix: trigger collapse with onchange Apr 2, 2021
@eschutho eschutho force-pushed the elizabeth/fix-collapse-bug branch from 07935ba to 74811c9 Compare April 2, 2021 01:57
@pull-request-size pull-request-size bot added size/M and removed size/L labels Apr 2, 2021
@codecov
Copy link

codecov bot commented Apr 2, 2021

Codecov Report

Merging #13927 (b91aa9e) into master (9156f08) will increase coverage by 0.25%.
The diff coverage is 86.11%.

❗ Current head b91aa9e differs from pull request most recent head 1b0e578. Consider uploading reports for the commit 1b0e578 to get more accurate results
Impacted file tree graph

@@            Coverage Diff             @@
##           master   #13927      +/-   ##
==========================================
+ Coverage   77.83%   78.08%   +0.25%     
==========================================
  Files         934      934              
  Lines       47320    47350      +30     
  Branches     5913     5943      +30     
==========================================
+ Hits        36831    36975     +144     
+ Misses      10346    10231     -115     
- Partials      143      144       +1     
Flag Coverage Δ
cypress 56.04% <42.85%> (+0.01%) ⬆️
hive ?
javascript 66.28% <86.20%> (+1.65%) ⬆️
presto ?

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...tend/src/SqlLab/components/ScheduleQueryButton.tsx 28.12% <ø> (ø)
...et-frontend/src/SqlLab/components/TableElement.jsx 88.60% <ø> (+0.23%) ⬆️
...rset-frontend/src/components/ProgressBar/index.tsx 100.00% <ø> (ø)
...ontrols/AnnotationLayerControl/AnnotationLayer.jsx 84.76% <ø> (ø)
...mponents/controls/AnnotationLayerControl/index.jsx 82.85% <ø> (ø)
...ponents/controls/DndColumnSelectControl/Option.tsx 100.00% <ø> (ø)
.../src/explore/components/controls/SelectControl.jsx 93.75% <ø> (ø)
.../explore/components/controls/TextControl/index.tsx 88.37% <ø> (ø)
superset/config.py 90.74% <ø> (ø)
...perset-frontend/src/explore/components/Control.tsx 91.66% <50.00%> (-3.79%) ⬇️
... and 36 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a144249...1b0e578. Read the comment docs.

@eschutho eschutho force-pushed the elizabeth/fix-collapse-bug branch from 74811c9 to 3deb1cb Compare April 2, 2021 16:34
@eschutho eschutho force-pushed the elizabeth/fix-collapse-bug branch from 3deb1cb to 1b0e578 Compare April 2, 2021 16:55
Copy link
Member

@suddjian suddjian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@junlincc
Copy link
Member

junlincc commented Apr 2, 2021

/testenv up

@github-actions
Copy link
Contributor

github-actions bot commented Apr 2, 2021

@junlincc Ephemeral environment spinning up at http://34.218.44.50:8080. Credentials are admin/admin. Please allow several minutes for bootstrapping and startup.

Copy link
Member

@pkdotson pkdotson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTG!

@pkdotson pkdotson merged commit abd4051 into apache:master Apr 3, 2021
@github-actions
Copy link
Contributor

github-actions bot commented Apr 3, 2021

Ephemeral environment shutdown and build artifacts deleted.

henryyeh pushed a commit to preset-io/superset that referenced this pull request Apr 6, 2021
lyndsiWilliams pushed a commit to preset-io/superset that referenced this pull request Apr 7, 2021
@eschutho eschutho deleted the elizabeth/fix-collapse-bug branch April 16, 2021 23:54
allanco91 pushed a commit to allanco91/superset that referenced this pull request May 21, 2021
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 1.2.0 labels Mar 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels preset-io size/M 🚢 1.2.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants