Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: CrossFilterScopingForm #13875

Merged
merged 4 commits into from
Apr 5, 2021
Merged

test: CrossFilterScopingForm #13875

merged 4 commits into from
Apr 5, 2021

Conversation

yardz
Copy link
Contributor

@yardz yardz commented Mar 30, 2021

SUMMARY

Tests for CrossFilterScopingForm

@codecov
Copy link

codecov bot commented Mar 31, 2021 •
edited
Loading

Codecov Report

Merging #13875 (098f478) into master (9d0bb3a) will increase coverage by 0.45%.
The diff coverage is 76.74%.

❗ Current head 098f478 differs from pull request most recent head c561188. Consider uploading reports for the commit c561188 to get more accurate results
Impacted file tree graph

@@            Coverage Diff             @@
##           master   #13875      +/-   ##
==========================================
+ Coverage   76.78%   77.23%   +0.45%     
==========================================
  Files         935      938       +3     
  Lines       47292    47727     +435     
  Branches     5895     6049     +154     
==========================================
+ Hits        36311    36863     +552     
+ Misses      10824    10721     -103     
+ Partials      157      143      -14
Flag Coverage Δ
cypress 56.03% <74.07%> (+3.72%) ⬆️
javascript 64.65% <78.18%> (+0.94%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...frontend/src/components/Checkbox/CheckboxIcons.tsx 85.71% <ø> (ø)
...frontend/src/components/DatabaseSelector/index.tsx 92.70% <ø> (+1.04%) ⬆️
superset-frontend/src/components/Icon/index.tsx 100.00% <ø> (ø)
...ontend/src/components/URLShortLinkButton/index.jsx 100.00% <ø> (ø)
...src/dashboard/components/dnd/handleScroll/index.ts 73.33% <ø> (ø)
...src/dashboard/components/filterscope/treeIcons.jsx 100.00% <ø> (ø)
...erset-frontend/src/datasource/DatasourceEditor.jsx 65.82% <0.00%> (ø)
...d/src/explore/components/DatasourcePanel/index.tsx 87.93% <ø> (ø)
...rc/explore/components/DisplayQueryButton/index.jsx 100.00% <ø> (ø)
...rontend/src/explore/components/EmbedCodeButton.jsx 80.76% <ø> (ø)
... and 124 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ce2760e...c561188. Read the comment docs.

@junlincc junlincc requested a review from amitmiran137 March 31, 2021 20:40
yardz and others added 3 commits April 1, 2021 11:21
@yardz @michael-s-molina
Update superset-frontend/src/dashboard/components/CrossFilterScopingM…
a6af3cb 
…odal/CrossFilterScopingForm/CrossFilterScopingForm.test.tsx

Co-authored-by: Michael S. Molina <[email protected]>
@yardz @michael-s-molina
Update superset-frontend/src/dashboard/components/CrossFilterScopingM…
80d784d 
…odal/CrossFilterScopingForm/CrossFilterScopingForm.test.tsx

Co-authored-by: Michael S. Molina <[email protected]>
@yardz @michael-s-molina
Update superset-frontend/src/dashboard/components/CrossFilterScopingM…
c561188 
…odal/CrossFilterScopingForm/CrossFilterScopingForm.test.tsx

Co-authored-by: Michael S. Molina <[email protected]>
rusackas
rusackas approved these changes Apr 5, 2021
View reviewed changes
Copy link
Member

@rusackas rusackas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@rusackas rusackas merged commit 203512e into apache:master Apr 5, 2021
@yardz yardz deleted the test-CrossFilterScopingForm branch April 5, 2021 19:14
lyndsiWilliams pushed a commit to preset-io/superset that referenced this pull request Apr 7, 2021
@yardz @michael-s-molina @lyndsiWilliams
test: CrossFilterScopingForm (apache#13875)
a0d8f14 
* tests for CrossFilterScopingForm

* Update superset-frontend/src/dashboard/components/CrossFilterScopingModal/CrossFilterScopingForm/CrossFilterScopingForm.test.tsx

Co-authored-by: Michael S. Molina <[email protected]>

* Update superset-frontend/src/dashboard/components/CrossFilterScopingModal/CrossFilterScopingForm/CrossFilterScopingForm.test.tsx

Co-authored-by: Michael S. Molina <[email protected]>

* Update superset-frontend/src/dashboard/components/CrossFilterScopingModal/CrossFilterScopingForm/CrossFilterScopingForm.test.tsx

Co-authored-by: Michael S. Molina <[email protected]>

Co-authored-by: Michael S. Molina <[email protected]>
allanco91 pushed a commit to allanco91/superset that referenced this pull request May 21, 2021
@yardz @michael-s-molina
test: CrossFilterScopingForm (apache#13875)
d84c3cb 
* tests for CrossFilterScopingForm

* Update superset-frontend/src/dashboard/components/CrossFilterScopingModal/CrossFilterScopingForm/CrossFilterScopingForm.test.tsx

Co-authored-by: Michael S. Molina <[email protected]>

* Update superset-frontend/src/dashboard/components/CrossFilterScopingModal/CrossFilterScopingForm/CrossFilterScopingForm.test.tsx

Co-authored-by: Michael S. Molina <[email protected]>

* Update superset-frontend/src/dashboard/components/CrossFilterScopingModal/CrossFilterScopingForm/CrossFilterScopingForm.test.tsx

Co-authored-by: Michael S. Molina <[email protected]>

Co-authored-by: Michael S. Molina <[email protected]>
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 1.2.0 labels Mar 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rusackas rusackas rusackas approved these changes

@michael-s-molina michael-s-molina michael-s-molina approved these changes

@amitmiran137 amitmiran137 Awaiting requested review from amitmiran137

Assignees
No one assigned
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels size/M test:component 🚢 1.2.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@yardz @rusackas @michael-s-molina @mistercrunch @junlincc