Added checkbox in dist_bar viz to enable sorting of bars based on x axis labels

[vera-liu]

Done:

• Added a checkbox for dist_bar viz
• Once toggled, distribution bars are ordered according to their x axis labels

Issue:
#519

Checkbox:

Before ordering:

After toggling checkbox and click 'Query' button:

needs-review @mistercrunch @ascott

[mistercrunch]

('order_bars', None) will render using half the column so that the checkbox is not too far away from the label.

[mistercrunch]

_("Sort bars by x labels"), for translation, and don't forget the trailing comma

[vera-liu]

Updated checkbox and tooltip message @mistercrunch

[vera-liu]

I have a question about this logic: https://github.com/airbnb/caravel/blob/63161b11c347d5a6d62f7ae7dc91fa3c30b5dc93/caravel/models.py#L1093
Why is orderby only applied when groupby is not specified? Is it possible to change elif to if here, so that orderby specified metrics and groupby could happen at the same time?

[mistercrunch]

LGTM!

[hongqp]

Sorry @vera-liu . I used #1379, and already can saw the "Sort Bars" checkbox on the page. But when I checked it and re-query, there is nothing changed. How can I do if I want enable sorting of bars based on x axis labels in dist_bar.

[vera-liu]

Hi, As shown in the gif, checking sort bars and hit query button will work. Are you on latest master?

…

On Thu, Dec 15, 2016 at 6:23 PM, hongqp ***@***.***> wrote: Sorry @vera-liu <https://github.com/vera-liu> . I used #1379 <#1379>, and already can saw the "Sort Bars" checkbox on the page. But when I checked it and re-query, there is nothing changed. How can I do if I want enable sorting of bars based on x axis labels in dist_bar. [image: default] <https://cloud.githubusercontent.com/assets/11678296/21249373/7d08dc7e-c378-11e6-85be-1c27e031cd39.png> — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#1379 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AUAafrq38tOUylhiXMP2-crXIgwO07sQks5rIfYhgaJpZM4Kbgnc> .

-- Best, Vera

[hongqp]

@vera-liu ，yes，it work when I updated the file “explore.0.12.0.entry.js”.
Thanks a lot.

[ondrejkopicka]

@vera-liu unfortunately labels are sorted only alphabetically. In case of numeric labels the resulting order is 1, 10, 101, 11, 2, 21, 3 instead of 1, 2, 3, 10, 11, 21, 101.

[skysaeed]

@vera-liu
there is a problem when sorting the labels like : 1, 2, 3, 4+
sometime it is sorted randomly