fix(dashboard): rename native filter configuration property

[villebro]

SUMMARY

The PR #13625 introduced a regression in the native filters feature, causing existing filter configurations to not show up on the Filter Tab and making it impossible to save affected dashboards. The reason for the regression was that the filter_configuration property in the dashboard's json_metadata object that contains all native filters had changed name to native_filter_configuration.

This PR migrates all existing dashboards that include native filter configurations from using the now deprecated filter_configuration to the new native_filter_configuration. Dashboards that were already using the new name are unaffected. The migration also limits the migration to dashboards that have native filter configurations, making this migration fairly light weight (won't touch any rows if the native filters feature was not activated).

TEST PLAN

1. Tested that a dashboard with the old metadata failed to load existing native filters and failed to update metadata
2. Tested up migration, and made sure it only modified dashboards with the old filter_configuration property to use the new native_filter_configuration property. Also made sure the dashboards loaded the filter configurations correctly, and were able to to save updated metadata.
3. Tested down migration, and made sure it changed the dashboards to use the old filter_configuration property. Also reran the up migration, and made sure dashboards with native filters were working again.

ADDITIONAL INFORMATION

• Has associated issue:
• Changes UI
• Requires DB Migration.
• Confirm DB Migration upgrade and downgrade tested.
• Introduces new feature or API
• Removes existing feature or API

[codecov]

Codecov Report

Merging #13769 (2b59f2d) into master (fd7c9eb) will decrease coverage by 0.07%.
The diff coverage is n/a.

❗ Current head 2b59f2d differs from pull request most recent head 1e0d114. Consider uploading reports for the commit 1e0d114 to get more accurate results

@@            Coverage Diff             @@
##           master   #13769      +/-   ##
==========================================
- Coverage   77.39%   77.32%   -0.08%     
==========================================
  Files         933      933              
  Lines       47186    47186              
  Branches     5872     5872              
==========================================
- Hits        36521    36486      -35     
- Misses      10523    10558      +35     
  Partials      142      142              

Flag	Coverage Δ
cypress	56.23% <ø> (ø)
hive	?
mysql	80.56% <ø> (ø)
postgres	80.59% <ø> (ø)
presto	80.25% <ø> (?)
python	80.83% <ø> (-0.14%)	⬇️
sqlite	80.15% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files	Coverage Δ
superset/db_engines/hive.py	0.00% <0.00%> (-85.72%)	⬇️
superset/db_engine_specs/hive.py	74.23% <0.00%> (-16.54%)	⬇️
superset/models/core.py	89.37% <0.00%> (+0.27%)	⬆️
superset/connectors/sqla/models.py	90.48% <0.00%> (+0.60%)	⬆️
superset/db_engine_specs/presto.py	88.28% <0.00%> (+5.43%)	⬆️

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fd7c9eb...1e0d114. Read the comment docs.

[junlin-qa]

oops i approved the wrong PR..

LGTM

[john-bodley]

@villebro I'm not sure if this migration was correct as it seems like the frontend defaults the native_filter_configuration to an empty list whereas you test for falsy and thus when someone views a dashboard the json_metadata will be updated and the viewer will be recorded as the person who last changed it.

cc: @michellethomas