Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(CI): use Presto docker image from starburst #13756

Merged
merged 1 commit into from
Mar 24, 2021

Conversation

ktmud
Copy link
Member

@ktmud ktmud commented Mar 23, 2021

SUMMARY

Docker image prestosql/presto is renamed to trinodb/trino and prestosql/presto now returns 404.

TrinoDB is also open source, however, it does not support connecting with PyHive's Presto client (you will get a must use Basic Auth or provide a "X-Trino-User" user header error if you try to do it).

The company behind Trino, Startburst, does provide a Presto-compatible version of Trino, published under starburstdata/presto.

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

N/A

TEST PLAN

CI should be fixed.

ADDITIONAL INFORMATION

  • Has associated issue:
  • Changes UI
  • Requires DB Migration.
  • Confirm DB Migration upgrade and downgrade tested.
  • Introduces new feature or API
  • Removes existing feature or API

@codecov
Copy link

codecov bot commented Mar 23, 2021

Codecov Report

Merging #13756 (3c630bf) into master (fd7c9eb) will decrease coverage by 0.13%.
The diff coverage is n/a.

❗ Current head 3c630bf differs from pull request most recent head 452fa2a. Consider uploading reports for the commit 452fa2a to get more accurate results
Impacted file tree graph

@@            Coverage Diff             @@
##           master   #13756      +/-   ##
==========================================
- Coverage   77.39%   77.26%   -0.14%     
==========================================
  Files         933      933              
  Lines       47186    47186              
  Branches     5872     5872              
==========================================
- Hits        36521    36459      -62     
- Misses      10523    10585      +62     
  Partials      142      142              
Flag Coverage Δ
cypress 56.23% <ø> (ø)
hive 80.25% <ø> (ø)
mysql ?
postgres ?
presto 80.25% <ø> (?)
python 80.73% <ø> (-0.25%) ⬇️
sqlite ?

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
superset/sql_validators/postgres.py 50.00% <0.00%> (-50.00%) ⬇️
superset/databases/commands/create.py 82.35% <0.00%> (-9.81%) ⬇️
superset/databases/commands/update.py 85.71% <0.00%> (-8.17%) ⬇️
superset/db_engine_specs/sqlite.py 90.62% <0.00%> (-6.25%) ⬇️
superset/utils/celery.py 86.20% <0.00%> (-3.45%) ⬇️
superset/models/core.py 85.83% <0.00%> (-3.27%) ⬇️
superset/databases/api.py 89.24% <0.00%> (-2.79%) ⬇️
superset/views/core.py 73.18% <0.00%> (-2.45%) ⬇️
superset/datasets/api.py 89.63% <0.00%> (-1.81%) ⬇️
superset/db_engine_specs/mysql.py 91.66% <0.00%> (-1.67%) ⬇️
... and 8 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fd7c9eb...452fa2a. Read the comment docs.

@ktmud ktmud force-pushed the rename-presto-docker branch from 4504892 to f00b44b Compare March 23, 2021 23:29
@ktmud ktmud changed the title fix(CI): rename presto docker image to trino fix(CI): use Presto docker image from starburst Mar 23, 2021
@ktmud ktmud force-pushed the rename-presto-docker branch from f00b44b to 452fa2a Compare March 24, 2021 00:36
Copy link
Member

@etr2460 etr2460 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm assuming ci passes

@ktmud ktmud merged commit 9773aba into apache:master Mar 24, 2021
@ktmud ktmud deleted the rename-presto-docker branch March 24, 2021 03:12
@willbarrett
Copy link
Member

LGTM

allanco91 pushed a commit to allanco91/superset that referenced this pull request May 21, 2021
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 1.2.0 labels Mar 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels size/XS 🚢 1.2.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants