-
Notifications
You must be signed in to change notification settings - Fork 14.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(build): update webpack jsx paths #13744
Conversation
Update webpack jsx paths to support windows builds/dev server
Codecov Report
@@ Coverage Diff @@
## master #13744 +/- ##
=======================================
Coverage 77.45% 77.46%
=======================================
Files 933 933
Lines 47144 47144
Branches 5848 5848
=======================================
+ Hits 36516 36520 +4
+ Misses 10485 10481 -4
Partials 143 143
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
You can close this if windows is not supported officially but seems like this is the only issue that prevents development on windows |
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. For admin, please label this issue |
Thanks for this PR! I wish I had a Windows machine to test! I'll try to find someone that does. |
@cemremengu are you able to rebase this and see if it's still needed on Webpack 5 (this PR was done against Webpack 4). If so, I'm happy to help get this through (I have a Windows machine on which I can test this) |
closing in favor of #18685 |
Update webpack jsx paths to support windows builds/dev server
closes #10997