Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(build): update webpack jsx paths #13744

Closed
wants to merge 1 commit into from
Closed

fix(build): update webpack jsx paths #13744

wants to merge 1 commit into from

Conversation

cemremengu
Copy link
Contributor

@cemremengu cemremengu commented Mar 23, 2021

Update webpack jsx paths to support windows builds/dev server

closes #10997

Update webpack jsx paths to support windows builds/dev server
@codecov
Copy link

codecov bot commented Mar 23, 2021

Codecov Report

Merging #13744 (f3e80f5) into master (5b79f84) will increase coverage by 0.00%.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master   #13744   +/-   ##
=======================================
  Coverage   77.45%   77.46%           
=======================================
  Files         933      933           
  Lines       47144    47144           
  Branches     5848     5848           
=======================================
+ Hits        36516    36520    +4     
+ Misses      10485    10481    -4     
  Partials      143      143           
Flag Coverage Δ
cypress 56.37% <ø> (+0.02%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...set-frontend/src/dashboard/util/getDropPosition.js 90.90% <0.00%> (ø)
...et-frontend/src/dashboard/components/Dashboard.jsx 89.47% <0.00%> (+4.21%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5b79f84...f3e80f5. Read the comment docs.

@cemremengu
Copy link
Contributor Author

cemremengu commented Mar 23, 2021

You can close this if windows is not supported officially but seems like this is the only issue that prevents development on windows

@junlincc junlincc added the new:contributor The author is a new contributor label Mar 23, 2021
@stale
Copy link

stale bot commented Jun 11, 2021

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. For admin, please label this issue .pinned to prevent stale bot from closing the issue.

@stale stale bot added the inactive Inactive for >= 30 days label Jun 11, 2021
@amitmiran137 amitmiran137 requested a review from rusackas June 28, 2021 13:12
@stale stale bot removed the inactive Inactive for >= 30 days label Jun 28, 2021
@rusackas
Copy link
Member

Thanks for this PR! I wish I had a Windows machine to test! I'll try to find someone that does.

@villebro
Copy link
Member

@cemremengu are you able to rebase this and see if it's still needed on Webpack 5 (this PR was done against Webpack 4). If so, I'm happy to help get this through (I have a Windows machine on which I can test this)

@nytai
Copy link
Member

nytai commented Feb 11, 2022

closing in favor of #18685

@nytai nytai closed this Feb 11, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
new:contributor The author is a new contributor size/XS
Projects
None yet
Development

Successfully merging this pull request may close these issues.

run “npm run build” failid in superset-frontend (0.37.0)
5 participants