Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: Adds tests to the TimeSeriesColumnControl component #13712

Conversation

michael-s-molina
Copy link
Member

SUMMARY

Adds tests to the TimeSeriesColumnControl component.

TEST PLAN

1 - Execute TimeSeriesColumnControl tests
2 - All tests should pass

@rusackas @junlincc

ADDITIONAL INFORMATION

  • Has associated issue:
  • Changes UI
  • Requires DB Migration.
  • Confirm DB Migration upgrade and downgrade tested.
  • Introduces new feature or API
  • Removes existing feature or API

@codecov
Copy link

codecov bot commented Mar 19, 2021

Codecov Report

Merging #13712 (d25eb47) into master (9156f08) will increase coverage by 0.54%.
The diff coverage is 100.00%.

❗ Current head d25eb47 differs from pull request most recent head d127c6e. Consider uploading reports for the commit d127c6e to get more accurate results
Impacted file tree graph

@@            Coverage Diff             @@
##           master   #13712      +/-   ##
==========================================
+ Coverage   77.83%   78.37%   +0.54%     
==========================================
  Files         934      934              
  Lines       47320    47317       -3     
  Branches     5913     5937      +24     
==========================================
+ Hits        36831    37086     +255     
+ Misses      10346    10087     -259     
- Partials      143      144       +1     
Flag Coverage Δ
cypress 56.06% <0.00%> (+0.03%) ⬆️
javascript 66.39% <100.00%> (+1.76%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...ontrols/AnnotationLayerControl/AnnotationLayer.jsx 84.76% <ø> (ø)
...mponents/controls/AnnotationLayerControl/index.jsx 82.85% <ø> (ø)
...ponents/controls/DndColumnSelectControl/Option.tsx 100.00% <ø> (ø)
.../src/explore/components/controls/SelectControl.jsx 93.75% <ø> (ø)
.../explore/components/controls/TextControl/index.tsx 88.37% <ø> (ø)
...ponents/controls/TimeSeriesColumnControl/index.jsx 100.00% <ø> (ø)
...ontrols/DndColumnSelectControl/DndColumnSelect.tsx 58.06% <100.00%> (+35.48%) ⬆️
...ontrols/DndColumnSelectControl/DndFilterSelect.tsx 45.38% <100.00%> (+36.15%) ⬆️
...ontrols/DndColumnSelectControl/DndMetricSelect.tsx 43.65% <100.00%> (+33.33%) ⬆️
.../controls/DndColumnSelectControl/OptionWrapper.tsx 84.84% <100.00%> (ø)
... and 14 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9156f08...d127c6e. Read the comment docs.

Copy link
Member

@geido geido left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great improvements to the tests! LGTM!

@rusackas
Copy link
Member

rusackas commented Apr 1, 2021

/testenv up

@github-actions
Copy link
Contributor

github-actions bot commented Apr 1, 2021

@rusackas Ephemeral environment spinning up at http://52.27.87.232:8080. Credentials are admin/admin. Please allow several minutes for bootstrapping and startup.

@michael-s-molina michael-s-molina force-pushed the tests-audit-time-series-column-control branch from 9117776 to ead0735 Compare April 1, 2021 11:47
@michael-s-molina michael-s-molina force-pushed the tests-audit-time-series-column-control branch from ead0735 to d127c6e Compare April 1, 2021 18:15
@junlincc
Copy link
Member

junlincc commented Apr 5, 2021

/testenv up

@junlincc
Copy link
Member

junlincc commented Apr 5, 2021

Manual testing plan: check all components in times series table chart.

Copy link
Member

@rusackas rusackas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@rusackas rusackas merged commit 61129f7 into apache:master Apr 5, 2021
@junlincc
Copy link
Member

junlincc commented Apr 5, 2021

Screen Shot 2021-04-05 at 11 04 04 AM

lgtm 🟢

@github-actions
Copy link
Contributor

github-actions bot commented Apr 5, 2021

Ephemeral environment shutdown and build artifacts deleted.

@github-actions
Copy link
Contributor

github-actions bot commented Apr 5, 2021

@junlincc Container image not yet published for this PR. Please try again when build is complete.

@github-actions
Copy link
Contributor

github-actions bot commented Apr 5, 2021

@junlincc Ephemeral environment creation failed. Please check the Actions logs for details.

lyndsiWilliams pushed a commit to preset-io/superset that referenced this pull request Apr 7, 2021
allanco91 pushed a commit to allanco91/superset that referenced this pull request May 21, 2021
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 1.2.0 labels Mar 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels size/L test:component 🚢 1.2.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants