-
Notifications
You must be signed in to change notification settings - Fork 14.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
test: Adds tests to the TimeSeriesColumnControl component #13712
test: Adds tests to the TimeSeriesColumnControl component #13712
Conversation
Codecov Report
@@ Coverage Diff @@
## master #13712 +/- ##
==========================================
+ Coverage 77.83% 78.37% +0.54%
==========================================
Files 934 934
Lines 47320 47317 -3
Branches 5913 5937 +24
==========================================
+ Hits 36831 37086 +255
+ Misses 10346 10087 -259
- Partials 143 144 +1
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great improvements to the tests! LGTM!
/testenv up |
@rusackas Ephemeral environment spinning up at http://52.27.87.232:8080. Credentials are |
9117776
to
ead0735
Compare
...end/src/explore/components/controls/TimeSeriesColumnControl/TimeSeriesColumnControl.test.tsx
Show resolved
Hide resolved
ead0735
to
d127c6e
Compare
/testenv up |
Manual testing plan: check all components in times series table chart. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Ephemeral environment shutdown and build artifacts deleted. |
@junlincc Container image not yet published for this PR. Please try again when build is complete. |
@junlincc Ephemeral environment creation failed. Please check the Actions logs for details. |
SUMMARY
Adds tests to the
TimeSeriesColumnControl
component.TEST PLAN
1 - Execute
TimeSeriesColumnControl
tests2 - All tests should pass
@rusackas @junlincc
ADDITIONAL INFORMATION