fix(cross-filters): only apply filters if ff is set #13704
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #13704 +/- ##
==========================================
- Coverage 77.38% 73.10% -4.28%
==========================================
Files 928 615 -313
Lines 47002 21860 -25142
Branches 5806 5717 -89
==========================================
- Hits 36371 15981 -20390
+ Misses 10488 5736 -4752
Partials 143 143
Flags with carried forward coverage won't be shown. Click here to find out more. Continue to review full report at Codecov.
|
villebro
commented
Mar 19, 2021
Comment on lines
-54
to
+56
| if (cur?.type === CHART_TYPE && currentChartId !== cur?.meta?.chartId) { | ||
| return [...new Set([...acc, ...cur?.parents, cur.id])]; | ||
| const { id, parents = [], type, meta } = cur; | ||
| if (type === CHART_TYPE && currentChartId !== meta?.chartId) { | ||
| return [...new Set([...acc, ...parents, id])]; |
There was a problem hiding this comment.
This raised an error when the metadata was malformed (cur.parents was missing)
amitmiran137
approved these changes
Mar 19, 2021
junlincc
added
the
dashboard:native-filters
junlincc
added
dashboard:cross-filters
allanco91
pushed a commit
to allanco91/superset
that referenced
this pull request
May 21, 2021
* fix(cross-filters): only apply filters if ff is set * fix missing parent
mistercrunch
added
🏷️ bot
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
Currently charts that emit cross filtering events will apply to the dashboard even if the feature flag isn't set. This PR makes sure that the
dataMaskobject doesn't contain any properties that haven't been explicitly enabled. Note thatownFiltersis passed through irrespective of either theDASHBOARD_NATIVE_FILTERSorDASHBOARD_CROSS_FILTERSbeing set.BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
TEST PLAN
ADDITIONAL INFORMATION