Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(cross-filter): fix scheme py #13665

Merged
merged 2 commits into from
Mar 17, 2021

Conversation

simcha90
Copy link
Contributor

@simcha90 simcha90 commented Mar 17, 2021

SUMMARY

Fix chart_configuration field in dashboard json metadata scheme.

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

TEST PLAN

ADDITIONAL INFORMATION

  • Has associated issue:
  • Changes UI
  • Requires DB Migration.
  • Confirm DB Migration upgrade and downgrade tested.
  • Introduces new feature or API
  • Removes existing feature or API

@codecov
Copy link

codecov bot commented Mar 17, 2021

Codecov Report

Merging #13665 (363f8d4) into master (0e0c99b) will decrease coverage by 5.20%.
The diff coverage is 100.00%.

❗ Current head 363f8d4 differs from pull request most recent head 35f8c48. Consider uploading reports for the commit 35f8c48 to get more accurate results
Impacted file tree graph

@@            Coverage Diff             @@
##           master   #13665      +/-   ##
==========================================
- Coverage   76.46%   71.26%   -5.21%     
==========================================
  Files         921      838      -83     
  Lines       46769    41805    -4964     
  Branches     5644     4334    -1310     
==========================================
- Hits        35761    29791    -5970     
- Misses      10848    12014    +1166     
+ Partials      160        0     -160     
Flag Coverage Δ
cypress 56.57% <ø> (+5.25%) ⬆️
hive 80.25% <100.00%> (ø)
javascript ?
mysql 80.55% <100.00%> (ø)
postgres 80.59% <100.00%> (-0.02%) ⬇️
presto 80.28% <100.00%> (ø)
python 81.08% <100.00%> (-0.03%) ⬇️
sqlite ?

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
superset/dashboards/schemas.py 99.36% <100.00%> (ø)
...uperset-frontend/src/dashboard/util/dnd-reorder.js 0.00% <0.00%> (-100.00%) ⬇️
...rset-frontend/src/dashboard/util/getEmptyLayout.js 0.00% <0.00%> (-100.00%) ⬇️
...et-frontend/src/components/Pagination/Ellipsis.tsx 0.00% <0.00%> (-100.00%) ⬇️
...-frontend/src/components/OmniContainer/Omnibar.tsx 0.00% <0.00%> (-100.00%) ⬇️
...frontend/src/components/ErrorMessage/IssueCode.tsx 0.00% <0.00%> (-100.00%) ⬇️
...rc/components/ErrorMessage/TimeoutErrorMessage.tsx 0.00% <0.00%> (-100.00%) ⬇️
...dashboard/components/resizable/ResizableHandle.jsx 0.00% <0.00%> (-100.00%) ⬇️
...tersConfigModal/Footer/CancelConfirmationAlert.tsx 0.00% <0.00%> (-100.00%) ⬇️
...ConfigModal/FiltersConfigForm/FilterScope/state.ts 0.00% <0.00%> (-100.00%) ⬇️
... and 507 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0e0c99b...35f8c48. Read the comment docs.

@junlincc junlincc added the dashboard:native-filters Related to the native filters of the Dashboard label Mar 17, 2021
@amitmiran137 amitmiran137 merged commit c0fc1ae into apache:master Mar 17, 2021
@junlincc junlincc added dashboard:cross-filters Related to the Dashboard cross filters and removed dashboard:native-filters Related to the native filters of the Dashboard labels Apr 27, 2021
allanco91 pushed a commit to allanco91/superset that referenced this pull request May 21, 2021
* fix: fix scehme py

* fix: fix scheme py
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 1.2.0 labels Mar 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels dashboard:cross-filters Related to the Dashboard cross filters size/XS 🚢 1.2.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants