-
Notifications
You must be signed in to change notification settings - Fork 14.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add 'extra' column to saved_queries GET #13662
Conversation
This column contains schedule information when the feature flag `SCHEDULED_QUERIES` is enabled. Adding it here makes it available through the REST API.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
+1
Codecov Report
@@ Coverage Diff @@
## master #13662 +/- ##
==========================================
+ Coverage 77.41% 80.96% +3.54%
==========================================
Files 918 310 -608
Lines 46673 25052 -21621
Branches 5720 0 -5720
==========================================
- Hits 36132 20283 -15849
+ Misses 10405 4769 -5636
+ Partials 136 0 -136
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Would be nice to add this new field here: https://github.com/apache/superset/blob/master/tests/queries/saved_queries/api_tests.py#L133
I'll make another PR to make sure that adding a new field actually breaks a test (not just removing one)
This column contains schedule information when the feature flag `SCHEDULED_QUERIES` is enabled. Adding it here makes it available through the REST API.
SUMMARY
This column contains schedule information when the feature flag
SCHEDULED_QUERIES
is enabled. Adding it here makes it availablethrough the REST API.
BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
TEST PLAN
manual