Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(explore): added debounce in DateFilterControl #13660

Merged
merged 1 commit into from
Mar 17, 2021
Merged

Conversation

zhaoyongjie
Copy link
Member

@zhaoyongjie zhaoyongjie commented Mar 17, 2021

SUMMARY

In order to optimize the error message output, make these changes

  1. added debounce in DateFilterControl request
  2. catching errors in API hander
  3. output traceback message only in debug log level

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

BEFORE

image

AFTER

image

ADDITIONAL INFORMATION

  • Has associated issue:
  • Changes UI
  • Requires DB Migration.
  • Confirm DB Migration upgrade and downgrade tested.
  • Introduces new feature or API
  • Removes existing feature or API

@zhaoyongjie zhaoyongjie requested a review from ktmud March 17, 2021 03:50
@zhaoyongjie zhaoyongjie added the explore:time Related to the time filters in Explore label Mar 17, 2021
@codecov
Copy link

codecov bot commented Mar 17, 2021

Codecov Report

Merging #13660 (c50a2b6) into master (98a26e7) will decrease coverage by 0.03%.
The diff coverage is 76.92%.

❗ Current head c50a2b6 differs from pull request most recent head 0976a9c. Consider uploading reports for the commit 0976a9c to get more accurate results
Impacted file tree graph

@@            Coverage Diff             @@
##           master   #13660      +/-   ##
==========================================
- Coverage   77.41%   77.37%   -0.04%     
==========================================
  Files         918      918              
  Lines       46673    46698      +25     
  Branches     5720     5732      +12     
==========================================
+ Hits        36132    36134       +2     
- Misses      10405    10428      +23     
  Partials      136      136              
Flag Coverage Δ
cypress 56.62% <75.00%> (+0.03%) ⬆️
hive 80.25% <66.66%> (+<0.01%) ⬆️
javascript 63.17% <20.00%> (+<0.01%) ⬆️
mysql ?
postgres 80.61% <66.66%> (+<0.01%) ⬆️
presto 80.28% <66.66%> (-0.01%) ⬇️
python 81.06% <66.66%> (-0.05%) ⬇️
sqlite 80.22% <66.66%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
superset-frontend/src/SqlLab/actions/sqlLab.js 63.03% <ø> (ø)
superset/views/api.py 71.42% <50.00%> (+0.51%) ⬆️
...nts/controls/DateFilterControl/DateFilterLabel.tsx 86.20% <80.00%> (+0.36%) ⬆️
superset/utils/date_parser.py 96.87% <100.00%> (ø)
...tend/src/explore/components/DisplayQueryButton.jsx 67.46% <0.00%> (-8.34%) ⬇️
superset/db_engine_specs/mysql.py 91.66% <0.00%> (-1.67%) ⬇️
superset/models/core.py 88.55% <0.00%> (-0.82%) ⬇️
superset/views/core.py 75.18% <0.00%> (-0.45%) ⬇️
superset/db_engine_specs/presto.py 88.28% <0.00%> (-0.42%) ⬇️
...set-frontend/src/dashboard/util/getDropPosition.js 92.42% <0.00%> (+1.51%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 98a26e7...0976a9c. Read the comment docs.

@junlincc junlincc requested review from willbarrett and nytai and removed request for rusackas, junlincc and ktmud March 17, 2021 04:12
@junlincc
Copy link
Member

@nytai hey Tai, this should fix the noisy error in the log. let's get it in.

cc @willbarrett @guhan

Copy link
Member

@villebro villebro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 👍

@junlincc junlincc added the need:merge The PR is ready to be merged label Mar 17, 2021
@nytai nytai merged commit 7b74eb2 into master Mar 17, 2021
@junlincc junlincc removed the need:merge The PR is ready to be merged label Mar 17, 2021
@amitmiran137 amitmiran137 deleted the datefilter_debounce branch March 29, 2021 18:17
allanco91 pushed a commit to allanco91/superset that referenced this pull request May 21, 2021
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 1.2.0 labels Mar 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels explore:time Related to the time filters in Explore size/M 🚢 1.2.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants