Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: 'Run in SQL Lab' redirect bug #13657

Merged
merged 1 commit into from
Mar 17, 2021

Conversation

mistercrunch
Copy link
Member

@mistercrunch mistercrunch commented Mar 16, 2021

SUMMARY

Fix a bug related to a POST + redirect issue, adding a trailing backslash fixes things

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

Screen Shot 2021-03-16 at 1 26 31 PM

Screen Shot 2021-03-16 at 1 26 03 PM

TEST PLAN

Manual

@codecov
Copy link

codecov bot commented Mar 16, 2021

Codecov Report

Merging #13657 (2898678) into master (21cc495) will decrease coverage by 4.26%.
The diff coverage is 0.00%.

❗ Current head 2898678 differs from pull request most recent head 1eab3d0. Consider uploading reports for the commit 1eab3d0 to get more accurate results
Impacted file tree graph

@@            Coverage Diff             @@
##           master   #13657      +/-   ##
==========================================
- Coverage   77.41%   73.14%   -4.27%     
==========================================
  Files         918      608     -310     
  Lines       46673    21653   -25020     
  Branches     5720     5720              
==========================================
- Hits        36131    15838   -20293     
+ Misses      10406     5679    -4727     
  Partials      136      136              
Flag Coverage Δ
cypress 56.58% <0.00%> (-0.01%) ⬇️
hive ?
javascript 63.17% <0.00%> (ø)
mysql ?
postgres ?
presto ?
python ?
sqlite ?

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
superset-frontend/src/chart/chartAction.js 78.00% <0.00%> (ø)
...set-frontend/src/dashboard/util/getDropPosition.js 90.90% <0.00%> (-1.52%) ⬇️
superset/queries/dao.py
superset/charts/commands/create.py
superset/annotation_layers/commands/bulk_delete.py
superset/models/cache.py
superset/reports/api.py
superset/security/__init__.py
superset/models/__init__.py
superset/queries/saved_queries/schemas.py
... and 302 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 21cc495...1eab3d0. Read the comment docs.

@junlincc junlincc added the need:merge The PR is ready to be merged label Mar 17, 2021
@mistercrunch mistercrunch merged commit 4bdb958 into apache:master Mar 17, 2021
@mistercrunch mistercrunch deleted the fix_redirect_sql branch March 17, 2021 04:47
cccs-rc pushed a commit to CybercentreCanada/superset that referenced this pull request Apr 14, 2021
allanco91 pushed a commit to allanco91/superset that referenced this pull request May 21, 2021
cccs-rc pushed a commit to CybercentreCanada/superset that referenced this pull request Mar 6, 2024
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 1.2.0 labels Mar 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels need:merge The PR is ready to be merged preset-io size/XS 🚢 1.2.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants