chore: metric refactor iteration 1 #13596
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #13596 +/- ##
==========================================
- Coverage 77.29% 73.09% -4.20%
==========================================
Files 910 606 -304
Lines 46359 21552 -24807
Branches 5633 5692 +59
==========================================
- Hits 35831 15754 -20077
+ Misses 10392 5662 -4730
Partials 136 136
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
zhaoyongjie
force-pushed
the
refactor_metric
branch
from
e173cde to
2d31ecd
Compare
villebro
approved these changes
Mar 12, 2021
Comment on lines
+19
to
+24
| import PropTypes from 'prop-types'; | ||
|
|
||
| export default PropTypes.shape({ | ||
| column_name: PropTypes.string.isRequired, | ||
| type: PropTypes.string, | ||
| }); |
There was a problem hiding this comment.
Note to other reviewers: the reason the columnType type is duplicated is to make it possible for these to start diverging in the future.
allanco91
pushed a commit
to allanco91/superset
that referenced
this pull request
May 21, 2021
mistercrunch
added
🏷️ bot
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
I will do some metric refactor, in order to PR review, need to move some files to sub-directory.
TEST PLAN
Only the file reference location has changed, no function changed.
ADDITIONAL INFORMATION