Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: Tests and dedicated directory for the SupersetResourceSelect Component #13508

Merged
merged 5 commits into from
Mar 15, 2021
Merged

test: Tests and dedicated directory for the SupersetResourceSelect Component #13508

merged 5 commits into from
Mar 15, 2021

Conversation

geido
Copy link
Member

@geido geido commented Mar 7, 2021

Moved the SupersetResourceSelect Component to its dedicated directory while refactoring the tests with react-testing-library.

@codecov
Copy link

codecov bot commented Mar 7, 2021

Codecov Report

Merging #13508 (28bd925) into master (7b370e6) will decrease coverage by 4.69%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #13508      +/-   ##
==========================================
- Coverage   77.22%   72.52%   -4.70%     
==========================================
  Files         912      629     -283     
  Lines       46034    21697   -24337     
  Branches     5587     5641      +54     
==========================================
- Hits        35549    15736   -19813     
+ Misses      10354     5827    -4527     
- Partials      131      134       +3     
Flag Coverage Δ
cypress 57.44% <ø> (-0.13%) ⬇️
hive ?
javascript 62.49% <ø> (-0.46%) ⬇️
mysql ?
postgres ?
presto ?
python ?
sqlite ?

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...nd/src/components/SupersetResourceSelect/index.tsx 90.32% <ø> (ø)
...c/filters/components/Select/SelectFilterPlugin.tsx 79.48% <0.00%> (-4.24%) ⬇️
...ters/FiltersConfigModal/FiltersConfigForm/state.ts 88.88% <0.00%> (-2.03%) ⬇️
...components/nativeFilters/FilterBar/FilterValue.tsx 85.45% <0.00%> (-1.82%) ⬇️
...dashboard/components/FiltersBadge/DetailsPanel.tsx 60.41% <0.00%> (-1.81%) ⬇️
superset-frontend/src/common/components/index.tsx 100.00% <0.00%> (ø)
superset-frontend/src/filters/components/index.ts 0.00% <0.00%> (ø)
...-frontend/src/visualizations/presets/MainPreset.js 100.00% <0.00%> (ø)
...d/src/filters/components/Time/TimeFilterPlugin.tsx 0.00% <0.00%> (ø)
...src/filters/components/Range/RangeFilterPlugin.tsx 0.00% <0.00%> (ø)
... and 330 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7b370e6...28bd925. Read the comment docs.

Copy link
Member

@michael-s-molina michael-s-molina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@geido
Copy link
Member Author

geido commented Mar 9, 2021

@junlincc @rusackas

Copy link
Member

@pkdotson pkdotson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@pkdotson pkdotson merged commit df5fb5a into apache:master Mar 15, 2021
allanco91 pushed a commit to allanco91/superset that referenced this pull request May 21, 2021
…mponent (apache#13508)

* Refactor

* Clean up

* Add license

* Use findBy
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 1.2.0 labels Mar 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels test:component 🚢 1.2.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants