-
Notifications
You must be signed in to change notification settings - Fork 14.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
test: Tests and dedicated directory for the SupersetResourceSelect Component #13508
test: Tests and dedicated directory for the SupersetResourceSelect Component #13508
Conversation
Codecov Report
@@ Coverage Diff @@
## master #13508 +/- ##
==========================================
- Coverage 77.22% 72.52% -4.70%
==========================================
Files 912 629 -283
Lines 46034 21697 -24337
Branches 5587 5641 +54
==========================================
- Hits 35549 15736 -19813
+ Misses 10354 5827 -4527
- Partials 131 134 +3
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
superset-frontend/src/components/SupersetResourceSelect/SupersetResourceSelect.test.tsx
Outdated
Show resolved
Hide resolved
superset-frontend/src/components/SupersetResourceSelect/SupersetResourceSelect.test.tsx
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
…mponent (apache#13508) * Refactor * Clean up * Add license * Use findBy
Moved the SupersetResourceSelect Component to its dedicated directory while refactoring the tests with react-testing-library.