Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: SHOW is not DML #13464

Merged
merged 2 commits into from
Mar 5, 2021
Merged

Conversation

betodealmeida
Copy link
Member

@betodealmeida betodealmeida commented Mar 4, 2021

SUMMARY

This came up during the Trino podcast (https://www.twitch.tv/videos/936663396), a user couldn't run SHOW CATALOGS because they hadn't enabled DML in the database. It shouldn't be necessary.

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

N/A

TEST PLAN

Added tests.

ADDITIONAL INFORMATION

  • Has associated issue:
  • Changes UI
  • Requires DB Migration.
  • Confirm DB Migration upgrade and downgrade tested.
  • Introduces new feature or API
  • Removes existing feature or API

Copy link
Member

@etr2460 etr2460 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yeah, i think this is safe

@pull-request-size pull-request-size bot added size/S and removed size/XS labels Mar 4, 2021
@codecov
Copy link

codecov bot commented Mar 5, 2021

Codecov Report

Merging #13464 (eb998a1) into master (0318b6d) will decrease coverage by 5.87%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #13464      +/-   ##
==========================================
- Coverage   77.36%   71.49%   -5.88%     
==========================================
  Files         906      804     -102     
  Lines       45699    40626    -5073     
  Branches     5522     4159    -1363     
==========================================
- Hits        35356    29045    -6311     
- Misses      10216    11581    +1365     
+ Partials      127        0     -127     
Flag Coverage Δ
cypress 57.92% <ø> (-0.02%) ⬇️
hive ?
javascript ?
mysql 80.34% <100.00%> (+0.02%) ⬆️
postgres 80.38% <100.00%> (+0.02%) ⬆️
python 80.47% <100.00%> (-0.28%) ⬇️
sqlite 80.00% <100.00%> (+0.02%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
superset/db_engine_specs/base.py 85.57% <100.00%> (-0.49%) ⬇️
...uperset-frontend/src/dashboard/util/dnd-reorder.js 0.00% <0.00%> (-100.00%) ⬇️
...rset-frontend/src/dashboard/util/getEmptyLayout.js 0.00% <0.00%> (-100.00%) ⬇️
...et-frontend/src/components/Pagination/Ellipsis.tsx 0.00% <0.00%> (-100.00%) ⬇️
...-frontend/src/components/OmniContainer/Omnibar.tsx 0.00% <0.00%> (-100.00%) ⬇️
...frontend/src/components/ErrorMessage/IssueCode.tsx 0.00% <0.00%> (-100.00%) ⬇️
...rc/components/ErrorMessage/TimeoutErrorMessage.tsx 0.00% <0.00%> (-100.00%) ⬇️
...dashboard/components/resizable/ResizableHandle.jsx 0.00% <0.00%> (-100.00%) ⬇️
...tersConfigModal/Footer/CancelConfirmationAlert.tsx 0.00% <0.00%> (-100.00%) ⬇️
...ConfigModal/FiltersConfigForm/FilterScope/state.ts 0.00% <0.00%> (-100.00%) ⬇️
... and 486 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0318b6d...eb998a1. Read the comment docs.

@betodealmeida betodealmeida merged commit 528ea9c into apache:master Mar 5, 2021
allanco91 pushed a commit to allanco91/superset that referenced this pull request May 21, 2021
* fix: SHOW is not DML

* Fix test
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 1.2.0 labels Mar 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels size/S 🚢 1.2.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants