-
Notifications
You must be signed in to change notification settings - Fork 14.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: SHOW is not DML #13464
fix: SHOW is not DML #13464
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yeah, i think this is safe
Codecov Report
@@ Coverage Diff @@
## master #13464 +/- ##
==========================================
- Coverage 77.36% 71.49% -5.88%
==========================================
Files 906 804 -102
Lines 45699 40626 -5073
Branches 5522 4159 -1363
==========================================
- Hits 35356 29045 -6311
- Misses 10216 11581 +1365
+ Partials 127 0 -127
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
* fix: SHOW is not DML * Fix test
SUMMARY
This came up during the Trino podcast (https://www.twitch.tv/videos/936663396), a user couldn't run
SHOW CATALOGS
because they hadn't enabledDML
in the database. It shouldn't be necessary.BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
N/A
TEST PLAN
Added tests.
ADDITIONAL INFORMATION